~sircmpwn/gmni-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH gmni] Makefile: install libgmni.a with 644 perms

Details
Message ID
<20210307163150.333489-1-arivigodr@gmail.com>
DKIM signature
pass
Download raw message
Patch: +1 -1
Hi!
Static libraries don't need execution perms. I know this is very minor,
but best practice is to give everything the least amount of necessary
privileges. Thus, I propose changing the install command to use 644 
perms.

Yours,
Ariadna

---
 Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Makefile b/Makefile
index 5e468e2..1064a1e 100644
--- a/Makefile
+++ b/Makefile
@@ -61,7 +61,7 @@ install: all install_docs
	mkdir -p $(LIBDIR)/pkgconfig
	install -m755 gmni $(BINDIR)/gmni
	install -m755 gmnlm $(BINDIR)/gmnlm
	install -m755 libgmni.a $(LIBDIR)/libgmni.a
	install -m644 libgmni.a $(LIBDIR)/libgmni.a
	install -m644 include/gmni/gmni.h $(INCLUDEDIR)/gmni/gmni.h
	install -m644 include/gmni/tofu.h $(INCLUDEDIR)/gmni/tofu.h
	install -m644 include/gmni/url.h $(INCLUDEDIR)/gmni/url.h
-- 
2.30.1
Details
Message ID
<C9RE6J6RV77Q.291HDMOTL0928@taiga>
In-Reply-To
<20210307163150.333489-1-arivigodr@gmail.com> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
Thanks!

To git@git.sr.ht:~sircmpwn/gmni
   42d8022..31dfd38  master -> master
Reply to thread Export thread (mbox)