~sircmpwn/gmni-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH] fix null dereference

Details
Message ID
<20220114145755.2400-1-temp.xanomes@volny.cz>
DKIM signature
pass
Download raw message
Patch: +1 -1
---
My previous patch failed to include null check on browser->page_title,
causing null dereference when title is not set. Oops.

 src/gmnlm.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gmnlm.c b/src/gmnlm.c
index f5b7480..3160327 100644
--- a/src/gmnlm.c
+++ b/src/gmnlm.c
@@ -614,7 +614,7 @@ do_prompts(const char *prompt, struct browser *browser)
	case 'm':
		if (in[1] != '\0' && !isspace(in[1])) break;
		char *title = in[1] ? &in[1] : browser->page_title;
		save_bookmark(browser, trim_ws(title));
		save_bookmark(browser, title ? trim_ws(title) : title);
		result = PROMPT_AGAIN;
		goto exit;
	case 'M':
-- 
2.34.1
Details
Message ID
<CH5HJ01XGEO8.3N01LMFN9SD2E@taiga>
In-Reply-To
<20220114145755.2400-1-temp.xanomes@volny.cz> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
Thanks!

To git@git.sr.ht:~sircmpwn/gmni
   0603755..b31e655  master -> master
Reply to thread Export thread (mbox)