~sircmpwn/hare-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
6 4

[PATCH hare] makefile: make $(DESTDIR)$(BINDIR) before installing to it

Details
Message ID
<171849846660.16782.1489207416487149200-0@git.sr.ht>
DKIM signature
missing
Download raw message
Patch: +1 -0
From: triallax <triallax@tutanota.com>

without this, the `install` command directly after would fail with this,
at least on Chimera Linux:

install: /usr/local/bin/harec: No such file or directory

Signed-off-by: triallax <triallax@tutanota.com>
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile b/Makefile
index 5de9853b..344fe801 100644
--- a/Makefile
+++ b/Makefile
@@ -108,6 +108,7 @@ check: $(BINOUT)/harec $(tests)
	@$(TDENV) ./tests/run

install: $(BINOUT)/harec
	mkdir -p -- $(DESTDIR)$(BINDIR)
	install -Dm755 $(BINOUT)/harec $(DESTDIR)$(BINDIR)/harec

uninstall:
-- 
2.43.4

[hare/patches] build failed

builds.sr.ht <builds@sr.ht>
Details
Message ID
<D210VO3SKBTM.1ZZJ5QRUND9IC@fra01>
In-Reply-To
<171849846660.16782.1489207416487149200-0@git.sr.ht> (view parent)
DKIM signature
missing
Download raw message
hare/patches: FAILED in 41s

[makefile: make $(DESTDIR)$(BINDIR) before installing to it][0] from [~triallax][1]

[0]: https://lists.sr.ht/~sircmpwn/hare-dev/patches/53319
[1]: triallax@tutanota.com

✗ #1252120 FAILED hare/patches/alpine.yml  https://builds.sr.ht/~sircmpwn/job/1252120
✗ #1252121 FAILED hare/patches/freebsd.yml https://builds.sr.ht/~sircmpwn/job/1252121
✗ #1252123 FAILED hare/patches/openbsd.yml https://builds.sr.ht/~sircmpwn/job/1252123
✗ #1252122 FAILED hare/patches/netbsd.yml  https://builds.sr.ht/~sircmpwn/job/1252122

Re: [PATCH hare] makefile: make $(DESTDIR)$(BINDIR) before installing to it

Lorenz (xha) <me@xha.li>
Details
Message ID
<Zm5mWX79EGnXS4cX@xha.li>
In-Reply-To
<171849846660.16782.1489207416487149200-0@git.sr.ht> (view parent)
DKIM signature
pass
Download raw message
apart from the fact that this patch does not apply (because the
subjectprefix should've been "PATCH harec"), isn't /usr/
the right PREFIX for linux and not /usr/local? so wouldn't
patching config.mk the right move?

Re: [PATCH hare] makefile: make $(DESTDIR)$(BINDIR) before installing to it

Details
Message ID
<rxsntmwjeyqu6w6jd3x4po7imq5e43ou33ijmxhtbn2iwlgdlu@eudidzgwa66n>
In-Reply-To
<Zm5mWX79EGnXS4cX@xha.li> (view parent)
DKIM signature
missing
Download raw message
On 24/06/16 06:13:13, Lorenz (xha) wrote:
> apart from the fact that this patch does not apply (because the
> subjectprefix should've been "PATCH harec"), isn't /usr/
> the right PREFIX for linux and not /usr/local? so wouldn't
> patching config.mk the right move?

Both /usr and /usr/local can be the 'right' PREFIX for linux. For BINDIR
hier(7) says for /usr/bin that it is the primary directory for
executable programs and /usr/local/bin is for binaries local to the
site. For most distros that usually means that the package manager
installs to /usr and manual-installations (e.g. make install) use
/usr/local.

However not every system will have all required directories --- though
usually only a problem with /usr/local. Hares makefile, for example,
starts of with a mkdir -p block.

Re: [PATCH hare] makefile: make $(DESTDIR)$(BINDIR) before installing to it

Details
Message ID
<O-WI4Iu--3-9@tutanota.com>
In-Reply-To
<Zm5mWX79EGnXS4cX@xha.li> (view parent)
DKIM signature
pass
Download raw message
yes, we use PREFIX=/usr, but chimera's package build system sets it up so that packages are built in an isolated build root, and the destdir is also a dedicated directory in that build root that is initially entirely empty, and so the build system of the package is responsible for creating the directories it needs for installation

Re: [PATCH hare] makefile: make $(DESTDIR)$(BINDIR) before installing to it

Details
Message ID
<O-WJv57--3-9@tutanota.com>
In-Reply-To
<O-WI4Iu--3-9@tutanota.com> (view parent)
DKIM signature
pass
Download raw message
also, another clarification, note that the error message in the commit is from me building harec manually outside chimera's packaging system, of course we do set PREFIX=/usr there as i mentioned

Re: [PATCH hare] makefile: make $(DESTDIR)$(BINDIR) before installing to it

Lorenz (xha) <me@xha.li>
Details
Message ID
<Zm75U2Hsyff6AxYh@xha.li>
In-Reply-To
<rxsntmwjeyqu6w6jd3x4po7imq5e43ou33ijmxhtbn2iwlgdlu@eudidzgwa66n> (view parent)
DKIM signature
pass
Download raw message
ah! thanks for the clarifications! :)
Reply to thread Export thread (mbox)