~sircmpwn/hare-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
4 3

[PATCH harec] src/gen: Rename *constexpr to *constant

Details
Message ID
<20230213104809.25400-1-contact+sr.ht@hacktivis.me>
DKIM signature
missing
Download raw message
Patch: +3 -3
From: "Haelwenn (lanodan) Monnier" <contact@hacktivis.me>

This fixes compilation with cproc, constexpr bein a keyword in C23.

Picked *constant to correspond to the same assignment in the
gen_data_item function.
---
 src/gen.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/gen.c b/src/gen.c
index 3328ab8..7c760bb 100644
--- a/src/gen.c
+++ b/src/gen.c
@@ -1882,9 +1882,9 @@ static void
gen_const_string_at(struct gen_context *ctx,
	const struct expression *expr, struct gen_value out)
{
	const struct expression_constant *constexpr = &expr->constant;
	const char *val = constexpr->string.value;
	size_t len = constexpr->string.len;
	const struct expression_constant *constant = &expr->constant;
	const char *val = constant->string.value;
	size_t len = constant->string.len;

	// TODO: Generate string data structure as global also?
	struct qbe_value global = mkqtmp(ctx, ctx->arch.ptr, "strdata.%d");
-- 
2.38.2

[harec/patches] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CQHDKDUPTM0Y.21LS6SWHS5JK7@cirno2>
In-Reply-To
<20230213104809.25400-1-contact+sr.ht@hacktivis.me> (view parent)
DKIM signature
missing
Download raw message
harec/patches: SUCCESS in 1m0s

[src/gen: Rename *constexpr to *constant][0] from [][1]

[0]: https://lists.sr.ht/~sircmpwn/hare-dev/patches/38969
[1]: contact+sr.ht@hacktivis.me

✓ #939686 SUCCESS harec/patches/alpine.yml  https://builds.sr.ht/~sircmpwn/job/939686
✓ #939688 SUCCESS harec/patches/netbsd.yml  https://builds.sr.ht/~sircmpwn/job/939688
✓ #939687 SUCCESS harec/patches/freebsd.yml https://builds.sr.ht/~sircmpwn/job/939687
Details
Message ID
<CQHG63TMFXKZ.3ADW1HZ6BUOY7@monch>
In-Reply-To
<20230213104809.25400-1-contact+sr.ht@hacktivis.me> (view parent)
DKIM signature
missing
Download raw message
thanks!

To git@git.sr.ht:~sircmpwn/harec
   aef98a9..4730fa6  master -> master

btw you'll probably run into issues with math.h, that was what was
blocking cproc compilation before
Details
Message ID
<Y+rj5inhRzsCvIwZ@cloudsdale.the-delta.net.eu.org>
In-Reply-To
<CQHG63TMFXKZ.3ADW1HZ6BUOY7@monch> (view parent)
DKIM signature
missing
Download raw message
[2023-02-13 12:51:41+0000] Ember Sawady:
>thanks!
>
>To git@git.sr.ht:~sircmpwn/harec
>   aef98a9..4730fa6  master -> master
>
>btw you'll probably run into issues with math.h, that was what was
>blocking cproc compilation before

Oh, I got something quite unexpected

cproc+linux-gnu: I can now entirely run run make ; make check with no issues
cproc+linux-musl: I get "cproc-qbe: long double is not yet supported"
Details
Message ID
<CQHX0CF75CYQ.2NPWW1H2TJ2Q7@monch>
In-Reply-To
<Y+rj5inhRzsCvIwZ@cloudsdale.the-delta.net.eu.org> (view parent)
DKIM signature
missing
Download raw message
On Tue Feb 14, 2023 at 1:29 AM UTC, Haelwenn (lanodan) Monnier wrote:
> cproc+linux-gnu: I can now entirely run run make ; make check with no issues
> cproc+linux-musl: I get "cproc-qbe: long double is not yet supported"

Yeah, that'd be the math.h issues I mentioned above
Reply to thread Export thread (mbox)