~sircmpwn/hare-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 3

[PATCH harec] rt::compile ensure tests fail when "invalid" Hare is valid

Details
Message ID
<20240414144150.81887-2-malloryadams@fastmail.com>
DKIM signature
pass
Download raw message
Patch: +6 -0
Signed-off-by: Mallory Adams <malloryadams@fastmail.com>
---
 rt/compile.ha | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/rt/compile.ha b/rt/compile.ha
index a09a360..2dd0a53 100644
--- a/rt/compile.ha
+++ b/rt/compile.ha
@@ -87,6 +87,12 @@ export fn compile(

	match (expected) {
	case void => void;
		const status = wexitstatus(wstatus);
		if (status == status::SUCCESS) {
			let s = "expected any failure, got success\n";
			write(2, constchar(s), len(s));
			return error;
		};
	case let expected: status =>
		const status = wexitstatus(wstatus);
		if (status != expected) {
-- 
2.44.0

[harec/patches] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<D0JXB6THQMBC.USYC1SLFN4IC@fra01>
In-Reply-To
<20240414144150.81887-2-malloryadams@fastmail.com> (view parent)
DKIM signature
missing
Download raw message
harec/patches: SUCCESS in 36s

[rt::compile ensure tests fail when "invalid" Hare is valid][0] from [Mallory Adams][1]

[0]: https://lists.sr.ht/~sircmpwn/hare-dev/patches/51010
[1]: malloryadams@fastmail.com

✓ #1195644 SUCCESS harec/patches/alpine.yml  https://builds.sr.ht/~sircmpwn/job/1195644
✓ #1195645 SUCCESS harec/patches/freebsd.yml https://builds.sr.ht/~sircmpwn/job/1195645
✓ #1195646 SUCCESS harec/patches/netbsd.yml  https://builds.sr.ht/~sircmpwn/job/1195646
✓ #1195647 SUCCESS harec/patches/openbsd.yml https://builds.sr.ht/~sircmpwn/job/1195647

Re: [harec/patches] build success

Details
Message ID
<27d4285f-53c5-42cd-aecc-4d148df29a2e@fastmail.com>
In-Reply-To
<D0JXB6THQMBC.USYC1SLFN4IC@fra01> (view parent)
DKIM signature
pass
Download raw message
In all the places (00-literals.ha) where rt::compile() is called with 
void, we're expecting the compiler to exit in failure. Without this 
patch, the "invalid" tests added in 
https://lists.sr.ht/~sircmpwn/hare-dev/patches/51024 do not actually 
cause the tests to fail. So I think somebody just made a little oopsie 
during a refactor. Fortunately, all of the "invalid" tests are still 
passing.
Details
Message ID
<D0KXZZC140NI.2S49UQ62FJXP8@turminal.net>
In-Reply-To
<20240414144150.81887-2-malloryadams@fastmail.com> (view parent)
DKIM signature
pass
Download raw message
Thanks!

To git@git.sr.ht:~sircmpwn/harec
   c0db5b1..868b7f0  master -> master
Reply to thread Export thread (mbox)