~sircmpwn/hare-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH hare] os::move: fix invalid match usage

Details
Message ID
<20240415233422.31643-1-bgs@turminal.net>
DKIM signature
pass
Download raw message
Patch: +5 -2
The first case was a subset of the second, which is not supposed to be
allowed, but isn't handled by harec yet.

Signed-off-by: Bor Grošelj Simić <bgs@turminal.net>
---
 fs/fs.ha | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/fs/fs.ha b/fs/fs.ha
index 66f74025..5e813460 100644
--- a/fs/fs.ha
+++ b/fs/fs.ha
@@ -111,9 +111,12 @@ export fn rename(fs: *fs, oldpath: str, newpath: str) (void | error) = {
// copy and remove if necessary.
export fn move(fs: *fs, oldpath: str, newpath: str) (void | error) = {
	match (rename(fs, oldpath, newpath)) {
	case (cannotrename | errors::unsupported) => void; // Fallback
	case let err: error =>
		return err;
		match (err) {
		case (cannotrename | errors::unsupported) => void; // Fallback
		case =>
			return err;
		};
	case void =>
		return; // Success
	};
-- 
2.43.0

[hare/patches] build failed

builds.sr.ht <builds@sr.ht>
Details
Message ID
<D0L2ZNYBNNLB.1SXL59YX3MTMP@fra01>
In-Reply-To
<20240415233422.31643-1-bgs@turminal.net> (view parent)
DKIM signature
missing
Download raw message
hare/patches: FAILED in 1m0s

[os::move: fix invalid match usage][0] from [Bor Grošelj Simić][1]

[0]: https://lists.sr.ht/~sircmpwn/hare-dev/patches/51044
[1]: bgs@turminal.net

✓ #1196838 SUCCESS hare/patches/openbsd.yml https://builds.sr.ht/~sircmpwn/job/1196838
✗ #1196836 FAILED  hare/patches/alpine.yml  https://builds.sr.ht/~sircmpwn/job/1196836
✓ #1196837 SUCCESS hare/patches/freebsd.yml https://builds.sr.ht/~sircmpwn/job/1196837
Reply to thread Export thread (mbox)