~sircmpwn/hare-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
4 3

[PATCH harelang.org] Remove vertical scrolling in specific situations

Details
Message ID
<20240726152232.29764-2-contact@willowbarraco.fr>
DKIM signature
pass
Download raw message
Patch: +5 -1
main max-width is 800, the v-padding is 128, meaning the @media
max-width should be 1056.

The .code-tutorial part got a larger max-width, the @media max-width
should then be 1456.

Signed-off-by: Willow Barraco <contact@willowbarraco.fr>
---
 assets/main.scss | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/assets/main.scss b/assets/main.scss
index c922961..0430cc3 100644
--- a/assets/main.scss
+++ b/assets/main.scss
@@ -62,7 +62,7 @@ main {
  max-width: 800px;
  margin: 0 auto;

  @media(max-width: 1000px) {
  @media(max-width: 1056px) {
    padding: 0;
  }
}
@@ -332,6 +332,10 @@ ol li {
.code-tutorial {
  max-width: 1200px;

  @media(max-width: 1456px) {
    padding: 0;
  }

  .content {
    margin-bottom: 16rem;
    max-width: 1000px;
-- 
2.45.2
Details
Message ID
<D2ZKOJRPVCGK.2NI5BZ1O7X0WL@willowbarraco.fr>
In-Reply-To
<20240726152232.29764-2-contact@willowbarraco.fr> (view parent)
DKIM signature
pass
Download raw message
I manage to still have 24px of vertical scrolling with a some very
specific zoom levels. But it is still an improvement to the status-quo.

[harelang.org/patches/.build.yml] build failed

builds.sr.ht <builds@sr.ht>
Details
Message ID
<D2ZKQ4KHW72X.GPB5LEBAJX3C@fra02>
In-Reply-To
<20240726152232.29764-2-contact@willowbarraco.fr> (view parent)
DKIM signature
missing
Download raw message
harelang.org/patches/.build.yml: FAILED in 2m58s

[Remove vertical scrolling in specific situations][0] from [Willow Barraco][1]

[0]: https://lists.sr.ht/~sircmpwn/hare-dev/patches/54112
[1]: contact@willowbarraco.fr

✗ #1286096 FAILED harelang.org/patches/.build.yml https://builds.sr.ht/~sircmpwn/job/1286096
Details
Message ID
<6752f3c3-50bf-4aca-95b6-715d8b3ea265@app.fastmail.com>
In-Reply-To
<D2ZKOJRPVCGK.2NI5BZ1O7X0WL@willowbarraco.fr> (view parent)
DKIM signature
pass
Download raw message
Hmm, I was a bit confused reading this. Could you explain what problem this is intended to solve with a more specific example?

Also, you refer to “vertical scrolling”, but I'm guessing you mean horizontal scrolling?

Lastly, because I haven't reproduced the problem I don't know what the best solution is, but in my experience these kinds of things are not usually solved by fiddling with numbers, hence you still being able to reproduce the issue. This should generally be fixed by setting properties such as `overflow` and `word-wrap` to appropriate values.
Details
Message ID
<D30F5Q2IWSYJ.34VMG5TFPZ7ZZ@willowbarraco.fr>
In-Reply-To
<6752f3c3-50bf-4aca-95b6-715d8b3ea265@app.fastmail.com> (view parent)
DKIM signature
pass
Download raw message
Right, sorry for that confusing patch. I sent this very fast.

And yes you right, I meant horizontal scrolling. Here what I see with
qutebrowser, on Sway 1080p scaled 1.4:

https://dav.missbanal.net/582e3821-05d2-4cc3-aacf-2836d20c9ef8.png

The tutorial page got this tiny scrolling, because the .main plus the
two paddings are to wides.
Reply to thread Export thread (mbox)