~sircmpwn/hare-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 3

[PATCH harelang.org] tutorials/introduction: Fix appearance of alert in for-each loops

Details
Message ID
<20240812000011.268608-2-me@runxiyu.org>
DKIM signature
pass
Download raw message
Patch: +2 -2
This commit partially reverts d2952709.

d2952709 replaced the broken `backtick quotes` with <pre>preformatted
blocks</pre>, but preformatted are actual block's rather than
inline-block's, which causes each of these to appear on a different line
and bleed out of the div.alert border on some some screen sizes.

This commits replaces them with <code>, which seems to work well in this
context.

Signed-off-by: Runxi Yu <me@runxiyu.org>
---
 content/tutorials/introduction.md | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/content/tutorials/introduction.md b/content/tutorials/introduction.md
index ebaa43c..356ba33 100644
--- a/content/tutorials/introduction.md
+++ b/content/tutorials/introduction.md
@@ -1252,8 +1252,8 @@ sections:
      useful functions yourself.

      <div class="alert">
        <strong>Note:</strong> It is not possible to <pre>insert</pre>,
        <pre>delete</pre>, <pre>free</pre> and <pre>append</pre> to the slice
        <strong>Note:</strong> It is not possible to <code>insert</code>,
        <code>delete</code>, <code>free</code> and <code>append</code> to the slice
        being iterated over. It is encouraged to use normal for loops for this
        use case instead.
      </div>
-- 
2.46.0

[harelang.org/patches/.build.yml] build failed

builds.sr.ht <builds@sr.ht>
Details
Message ID
<D3DY9JQR84VT.2XB77ZD1DIL2J@fra01>
In-Reply-To
<20240812000011.268608-2-me@runxiyu.org> (view parent)
DKIM signature
missing
Download raw message
harelang.org/patches/.build.yml: FAILED in 2m57s

[tutorials/introduction: Fix appearance of alert in for-each loops][0] from [Runxi Yu][1]

[0]: https://lists.sr.ht/~sircmpwn/hare-dev/patches/54434
[1]: me@runxiyu.org

✗ #1301314 FAILED harelang.org/patches/.build.yml https://builds.sr.ht/~sircmpwn/job/1301314
Details
Message ID
<D3DYBUK3OYA9.36NM9QP5TYIDN@runxiyu.org>
In-Reply-To
<20240812000011.268608-2-me@runxiyu.org> (view parent)
DKIM signature
pass
Download raw message
> https://builds.sr.ht/~sircmpwn/job/1301314

I see that the builds.sr.ht job for this patch is running. The "upload" 
step failed (which is probably expected), but I see that you're 
installing TeXLive from scratch.

Generating TeXLive formats uses a lot of resources; when I install a 
Linux-based system that I use day-to-day (well, a binary-based one, not 
Gentoo or anything like that), the single longest task is running the 
scripts that generate TeX formats (kpathsea, mktex*, etc). If at all 
possible, I'd suggest using an image that has TeX Live included; it's 
not like TeX Live gets many updates either, in most cases it's just once 
a year releases.

--
Best regards,
Runxi Yu (they/them)
https://runxiyu.org/
Details
Message ID
<D6O413AHQVNO.177U7FYS1VBJ2@cmpwn.com>
In-Reply-To
<20240812000011.268608-2-me@runxiyu.org> (view parent)
DKIM signature
pass
Download raw message
I noticed this issue and fixed it independently the other day without
realizing that there was a pending patch for it. Sorry for missing this.
Reply to thread Export thread (mbox)