~sircmpwn/hare-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH hare] hare+libc.sc: Separate .test_array from RELRO sections

Details
Message ID
<20240912161959.13377-1-yyp@disroot.org>
DKIM signature
pass
Download raw message
Patch: +8 -2
In some configurations (on FreeBSD, or on LLD <= 17), putting
.test_array between RELRO sections (for example, between .dynamic and
.got.plt) caused a linking failure.

Signed-off-by: Alexey Yerin <yyp@disroot.org>
---
 rt/+freebsd/hare+libc.sc | 5 ++++-
 rt/+linux/hare+libc.sc   | 5 ++++-
 2 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/rt/+freebsd/hare+libc.sc b/rt/+freebsd/hare+libc.sc
index ade57fe4..9471408e 100644
--- a/rt/+freebsd/hare+libc.sc
+++ b/rt/+freebsd/hare+libc.sc
@@ -4,9 +4,12 @@ SECTIONS {
		KEEP(*(.init_array))
		PROVIDE(__libc_init_array_end = .);
	}
} INSERT AFTER .dynamic;

SECTIONS {
	.test_array : {
		PROVIDE(__test_array_start = .);
		KEEP(*(.test_array*))
		PROVIDE(__test_array_end = .);
	}
} INSERT AFTER .dynamic;
} INSERT AFTER .bss;
diff --git a/rt/+linux/hare+libc.sc b/rt/+linux/hare+libc.sc
index ade57fe4..9471408e 100644
--- a/rt/+linux/hare+libc.sc
+++ b/rt/+linux/hare+libc.sc
@@ -4,9 +4,12 @@ SECTIONS {
		KEEP(*(.init_array))
		PROVIDE(__libc_init_array_end = .);
	}
} INSERT AFTER .dynamic;

SECTIONS {
	.test_array : {
		PROVIDE(__test_array_start = .);
		KEEP(*(.test_array*))
		PROVIDE(__test_array_end = .);
	}
} INSERT AFTER .dynamic;
} INSERT AFTER .bss;
-- 
2.46.0

[hare/patches] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<D44FYX4H8NAQ.38WBFD88LHHVV@fra01>
In-Reply-To
<20240912161959.13377-1-yyp@disroot.org> (view parent)
DKIM signature
missing
Download raw message
hare/patches: SUCCESS in 1m9s

[hare+libc.sc: Separate .test_array from RELRO sections][0] from [Alexey Yerin][1]

[0]: https://lists.sr.ht/~sircmpwn/hare-dev/patches/55007
[1]: yyp@disroot.org

✓ #1326363 SUCCESS hare/patches/freebsd.yml https://builds.sr.ht/~sircmpwn/job/1326363
✓ #1326362 SUCCESS hare/patches/alpine.yml  https://builds.sr.ht/~sircmpwn/job/1326362
✓ #1326365 SUCCESS hare/patches/openbsd.yml https://builds.sr.ht/~sircmpwn/job/1326365
✓ #1326364 SUCCESS hare/patches/netbsd.yml  https://builds.sr.ht/~sircmpwn/job/1326364
Details
Message ID
<D44J8XM9DIVH.2PIYN4J2HZBDB@d2evs.net>
In-Reply-To
<20240912161959.13377-1-yyp@disroot.org> (view parent)
DKIM signature
pass
Download raw message
thanks!

to git@git.sr.ht:~sircmpwn/hare
  00a3bc1d..d49e2d9c  master -> master
Reply to thread Export thread (mbox)