hare: cmd/hare: Use LDLINKFLAGS instead of LDFLAGS v1 APPLIED

Haelwenn (lanodan) Monnier: 1
 cmd/hare: Use LDLINKFLAGS instead of LDFLAGS

 2 files changed, 2 insertions(+), 2 deletions(-)

[2023-02-03 18:31:11+0000] Ember Sawady:

[PATCH hare] cmd/hare: Use LDLINKFLAGS instead of LDFLAGS Export this patch

From: "Haelwenn (lanodan) Monnier" <contact@hacktivis.me>

Implements: https://todo.sr.ht/~sircmpwn/hare/784
Signed-off-by: Haelwenn (lanodan) Monnier <contact@hacktivis.me>
---
 cmd/hare/schedule.ha | 2 +-
 docs/hare.scd        | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/cmd/hare/schedule.ha b/cmd/hare/schedule.ha
index 643a80e9..f082f5aa 100644
--- a/cmd/hare/schedule.ha
+++ b/cmd/hare/schedule.ha
@@ -40,7 +40,7 @@ fn getenv(var: str) []str = {
 // (executable name, executable variable, flags variable)
 type tool = (str, str, str);
 
-let ld_tool: tool = ("", "LD", "LDFLAGS");
+let ld_tool: tool = ("", "LD", "LDLINKFLAGS");
 let as_tool: tool = ("", "AS", "ASFLAGS");
 let ar_tool: tool = ("", "AR", "ARFLAGS");
 let qbe_tool: tool = ("qbe", "QBE", "QBEFLAGS");
diff --git a/docs/hare.scd b/docs/hare.scd
index ba23eb25..9e08a4cc 100644
--- a/docs/hare.scd
+++ b/docs/hare.scd
@@ -297,7 +297,7 @@ The following environment variables affect *hare*'s execution:
 :  Additional flags to pass to *as*(1).
 |  *LD*
 :  Name of the *ld*(1) command to use.
-|  *LDFLAGS*
+|  *LDLINKFLAGS*
 :  Additional flags to pass to *ld*(1).
 
 # SEE ALSO
-- 
2.39.1

Jose Lombera <jose@lombera.dev>

2 years ago

The LD and LINK parts in LDLINKFLAGS is redundant.

If this is going to be hare specific, why don't call it HARELDFLAGS
instead?

builds.sr.ht <builds@sr.ht>

2 years ago

hare/patches: SUCCESS in 3m40s

[cmd/hare: Use LDLINKFLAGS instead of LDFLAGS][0] from [Haelwenn (lanodan) Monnier][1]

[0]: https://lists.sr.ht/~sircmpwn/hare-dev/patches/38694
[1]: mailto:contact+sr.ht@hacktivis.me

✓ #933864 SUCCESS hare/patches/alpine.yml  https://builds.sr.ht/~sircmpwn/job/933864
✓ #933865 SUCCESS hare/patches/freebsd.yml https://builds.sr.ht/~sircmpwn/job/933865

Drew DeVault <sir@cmpwn.com>

1 year, 11 months ago

Thanks!

To git@git.sr.ht:~sircmpwn/hare
   772ec67d..b76e834c  master -> master