hare: os+freebsd: Do not invert CLOEXEC/CTTY twice v1 APPLIED

Alexey Yerin: 1
 os+freebsd: Do not invert CLOEXEC/CTTY twice

 1 files changed, 0 insertions(+), 2 deletions(-)

[PATCH hare] os+freebsd: Do not invert CLOEXEC/CTTY twice Export this patch

It's already inverted in fsflags_to_bsd and shouldn't be inverted once again in
open or create.

Signed-off-by: Alexey Yerin <yyp@disroot.org>
---
 os/+freebsd/dirfdfs.ha | 2 --
 1 file changed, 2 deletions(-)

diff --git a/os/+freebsd/dirfdfs.ha b/os/+freebsd/dirfdfs.ha
index 637fa51c..60acdd39 100644
--- a/os/+freebsd/dirfdfs.ha
+++ b/os/+freebsd/dirfdfs.ha
@@ -174,7 +174,6 @@ fn fs_open_file(
 	for (let i = 0z; i < len(flags); i += 1z) {
 		oflags |= flags[i];
 	};
-	oflags ^= fs::flag::CTTY | fs::flag::NOCLOEXEC; // invert NOCTTY/CLOEXEC
 	return _fs_open(fs, path, fsflags_to_bsd(oflags), 0);
 };
 
@@ -197,7 +196,6 @@ fn fs_create_file(
 	for (let i = 0z; i < len(flags); i += 1z) {
 		oflags |= flags[i];
 	};
-	oflags ^= fs::flag::CTTY | fs::flag::NOCLOEXEC; // invert NOCTTY/CLOEXEC
 	oflags |= fs::flag::CREATE;
 	return _fs_open(fs, path, fsflags_to_bsd(oflags), mode)?;
 };
-- 
2.42.0

builds.sr.ht <builds@sr.ht>

2 months ago

hare/patches: SUCCESS in 1m34s

[os+freebsd: Do not invert CLOEXEC/CTTY twice][0] from [Alexey Yerin][1]

[0]: https://lists.sr.ht/~sircmpwn/hare-dev/patches/44920
[1]: mailto:yyp@disroot.org

✓ #1060732 SUCCESS hare/patches/freebsd.yml https://builds.sr.ht/~sircmpwn/job/1060732
✓ #1060731 SUCCESS hare/patches/alpine.yml  https://builds.sr.ht/~sircmpwn/job/1060731

Drew DeVault <sir@cmpwn.com>

2 months ago

Thanks!

To git@git.sr.ht:~sircmpwn/hare
   4e3586a1..cb2477b0  master -> master