hare: makefile: make $(DESTDIR)$(BINDIR) before installing to it v1 PROPOSED

~triallax: 1
 makefile: make $(DESTDIR)$(BINDIR) before installing to it

 1 files changed, 1 insertions(+), 0 deletions(-)

yes, we use PREFIX=/usr, but chimera's package build system sets it up so that packages are built in an isolated build root, and the destdir is also a dedicated directory in that build root that is initially entirely empty, and so the build system of the package is responsible for creating the directories it needs for installation

ah! thanks for the clarifications! :)

also, another clarification, note that the error message in the commit is from me building harec manually outside chimera's packaging system, of course we do set PREFIX=/usr there as i mentioned

[PATCH hare] makefile: make $(DESTDIR)$(BINDIR) before installing to it Export this patch

From: triallax <triallax@tutanota.com>

without this, the `install` command directly after would fail with this,
at least on Chimera Linux:

install: /usr/local/bin/harec: No such file or directory

Signed-off-by: triallax <triallax@tutanota.com>
---
 Makefile | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Makefile b/Makefile
index 5de9853b..344fe801 100644
--- a/Makefile
+++ b/Makefile
@@ -108,6 +108,7 @@ check: $(BINOUT)/harec $(tests)
 	@$(TDENV) ./tests/run
 
 install: $(BINOUT)/harec
+	mkdir -p -- $(DESTDIR)$(BINDIR)
 	install -Dm755 $(BINOUT)/harec $(DESTDIR)$(BINDIR)/harec
 
 uninstall:
-- 
2.43.4

builds.sr.ht <builds@sr.ht>

7 months ago

hare/patches: FAILED in 41s

[makefile: make $(DESTDIR)$(BINDIR) before installing to it][0] from [~triallax][1]

[0]: https://lists.sr.ht/~sircmpwn/hare-dev/patches/53319
[1]: mailto:triallax@tutanota.com

✗ #1252120 FAILED hare/patches/alpine.yml  https://builds.sr.ht/~sircmpwn/job/1252120
✗ #1252121 FAILED hare/patches/freebsd.yml https://builds.sr.ht/~sircmpwn/job/1252121
✗ #1252123 FAILED hare/patches/openbsd.yml https://builds.sr.ht/~sircmpwn/job/1252123
✗ #1252122 FAILED hare/patches/netbsd.yml  https://builds.sr.ht/~sircmpwn/job/1252122

Lorenz (xha) <me@xha.li>

7 months ago

apart from the fact that this patch does not apply (because the
subjectprefix should've been "PATCH harec"), isn't /usr/
the right PREFIX for linux and not /usr/local? so wouldn't
patching config.mk the right move?