6 2

[PATCH 1/2] Fix build

Details
Message ID
<20190210214614.22586-1-mail@eliasnaur.com>
Sender timestamp
1549835173
DKIM signature
fail
Download raw message
Patch: +3 -2 DKIM signature: fail
---
 widgets/account.go | 2 +-
 widgets/aerc.go    | 3 ++-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/widgets/account.go b/widgets/account.go
index 70686fb..3848bbf 100644
--- a/widgets/account.go
+++ b/widgets/account.go
@@ -86,7 +86,7 @@ func NewAccountView(conf *config.AccountConfig,
 	return acct
 }
 
-func (acct *AccountView) Children() []Drawable {
+func (acct *AccountView) Children() []ui.Drawable {
 	return acct.grid.Children()
 }
 
diff --git a/widgets/aerc.go b/widgets/aerc.go
index 1ee4994..26dc5f2 100644
--- a/widgets/aerc.go
+++ b/widgets/aerc.go
@@ -7,6 +7,7 @@ import (
 	"github.com/gdamore/tcell"
 
 	"git.sr.ht/~sircmpwn/aerc2/config"
+	"git.sr.ht/~sircmpwn/aerc2/lib/ui"
 	libui "git.sr.ht/~sircmpwn/aerc2/lib/ui"
 )
 
@@ -49,7 +50,7 @@ func NewAerc(conf *config.AercConfig, logger *log.Logger) *Aerc {
 	return aerc
 }
 
-func (aerc *Aerc) Children() []Drawable {
+func (aerc *Aerc) Children() []ui.Drawable {
 	return aerc.grid.Children()
 }
 
-- 
2.20.1

[PATCH 2/2] Add missing go.sum entries

Details
Message ID
<20190210214614.22586-2-mail@eliasnaur.com>
In-Reply-To
<20190210214614.22586-1-mail@eliasnaur.com> (view parent)
Sender timestamp
1549835174
DKIM signature
fail
Download raw message
Patch: +6 -0 DKIM signature: fail
---
 go.sum | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/go.sum b/go.sum
index 169cb9b..c6e943f 100644
--- a/go.sum
+++ b/go.sum
@@ -4,13 +4,19 @@ github.com/emersion/go-imap-idle v0.0.0-20180114101550-2af93776db6b h1:q4qkNe/W1
 github.com/emersion/go-imap-idle v0.0.0-20180114101550-2af93776db6b/go.mod h1:o14zPKCmEH5WC1vU5SdPoZGgNvQx7zzKSnxPQlobo78=
 github.com/emersion/go-sasl v0.0.0-20161116183048-7e096a0a6197 h1:rDJPbyliyym8ZL/Wt71kdolp6yaD4fLIQz638E6JEt0=
 github.com/emersion/go-sasl v0.0.0-20161116183048-7e096a0a6197/go.mod h1:G/dpzLu16WtQpBfQ/z3LYiYJn3ZhKSGWn83fyoyQe/k=
+github.com/gdamore/encoding v0.0.0-20151215212835-b23993cbb635 h1:hheUEMzaOie/wKeIc1WPa7CDVuIO5hqQxjS+dwTQEnI=
 github.com/gdamore/encoding v0.0.0-20151215212835-b23993cbb635/go.mod h1:yrQYJKKDTrHmbYxI7CYi+/hbdiDT2m4Hj+t0ikCjsrQ=
+github.com/gdamore/tcell v1.0.0 h1:oaly4AkxvDT5ffKHV/n4L8iy6FxG2QkAVl0M6cjryuE=
 github.com/gdamore/tcell v1.0.0/go.mod h1:tqyG50u7+Ctv1w5VX67kLzKcj9YXR/JSBZQq/+mLl1A=
+github.com/go-ini/ini v1.32.0 h1:/MArBHSS0TFR28yPPDK1vPIjt4wUnPBfb81i6iiyKvA=
 github.com/go-ini/ini v1.32.0/go.mod h1:ByCAeIL28uOIIG0E3PJtZPDL8WnHpFKFOtgjp+3Ies8=
+github.com/kyoh86/xdg v0.0.0-20171127140545-8db68a8ea76a h1:vLFQnHOnCnmlySdpHAKF+mH7MhsthJgpBbfexVhHwxY=
 github.com/kyoh86/xdg v0.0.0-20171127140545-8db68a8ea76a/go.mod h1:Z5mDqe0fxyxn3W2yTxsBAOQqIrXADQIh02wrTnaRM38=
+github.com/lucasb-eyer/go-colorful v0.0.0-20180531031333-d9cec903b20c h1:b11Y3yxg40v2/9KUz76a4mSC1DMlgnPGAt+4pJSgmyU=
 github.com/lucasb-eyer/go-colorful v0.0.0-20180531031333-d9cec903b20c/go.mod h1:NXg0ArsFk0Y01623LgUqoqcouGDB+PwCCQlrwrG6xJ4=
 github.com/mattn/go-isatty v0.0.3 h1:ns/ykhmWi7G9O+8a448SecJU3nSMBXJfqQkl0upE1jI=
 github.com/mattn/go-isatty v0.0.3/go.mod h1:M+lRXTBqGeGNdLjl/ufCoiOlB5xdOkqRJdNxMWT7Zi4=
+github.com/mattn/go-runewidth v0.0.2 h1:UnlwIPBGaTZfPQ6T1IGzPI0EkYAQmT9fAEJ/poFC63o=
 github.com/mattn/go-runewidth v0.0.2/go.mod h1:LwmH8dsx7+W8Uxz3IHJYH5QSwggIsqBzpuz5H//U1FU=
 github.com/nsf/termbox-go v0.0.0-20180129072728-88b7b944be8b/go.mod h1:IuKpRQcYE1Tfu+oAQqaLisqDeXgjyyltCfsaoYN18NQ=
 golang.org/x/text v0.3.0 h1:g61tztE5qeGQ89tm6NTjjM9VPIm088od1l6aSorWRWg=
-- 
2.20.1
Details
Message ID
<cc5b1802d229a2f0c64a9b7c493473cb2499090b.camel@gmail.com>
In-Reply-To
<20190210214614.22586-1-mail@eliasnaur.com> (view parent)
Sender timestamp
1549835822
DKIM signature
pass
Download raw message
On Sun, 2019-02-10 at 22:46 +0100, Elias Naur wrote:
> *log.Logger) *Aerc {

Might want to use [PATCH aerc2 x/n] in your subjects from now on, to
clarify that your patches are for that project.

-- 
pmc

Re: [PATCH 2/2] Add missing go.sum entries

Details
Message ID
<rPyyz6d8AGhCSQAG9fVtDiDfuVikWgwSMr9eeLkQ7LjEhXeKSxD-y5LM8zfWKhNpUmKMx8QUQuwzjawvIWmM0kGsZ8W9xXgrbzN_DxG248M=@emersion.fr>
In-Reply-To
<20190210214614.22586-2-mail@eliasnaur.com> (view parent)
Sender timestamp
1549836406
DKIM signature
pass
Download raw message
I guess this is a aerc2 patch?

Maintainers can choose whether they want to include go.sum or not in
their repos. I often choose not to.

Re: [PATCH 2/2] Add missing go.sum entries

Details
Message ID
<CAMAFT9W0wrwVDogMVsHcrGqytSO4-3Yno4EmT2jgG4eDSvD1uw@mail.gmail.com>
In-Reply-To
<rPyyz6d8AGhCSQAG9fVtDiDfuVikWgwSMr9eeLkQ7LjEhXeKSxD-y5LM8zfWKhNpUmKMx8QUQuwzjawvIWmM0kGsZ8W9xXgrbzN_DxG248M=@emersion.fr> (view parent)
Sender timestamp
1549836627
DKIM signature
fail
Download raw message
DKIM signature: fail
> I guess this is a aerc2 patch?
>

Yes. Sorry for leaving that information out, it's my first time with
git send-mail.

> Maintainers can choose whether they want to include go.sum or not in
> their repos. I often choose not to.

go.sum exists in the repository, and the additions was added automatically by
go build.

Re: [PATCH 2/2] Add missing go.sum entries

Details
Message ID
<20190210221212.GA20462@homura.localdomain>
In-Reply-To
<20190210214614.22586-2-mail@eliasnaur.com> (view parent)
Sender timestamp
1549836732
DKIM signature
pass
Download raw message
Thanks! Pushed both patches:

To git.sr.ht:~sircmpwn/aerc2
   1228448..62862d8  master -> master

If you run this on that git repo, you won't encounter the project
confusion again:

	git config format.subjectPrefix 'PATCH aerc2'

Cheers!

Re: [PATCH 2/2] Add missing go.sum entries

Details
Message ID
<Z0oLMOVk30AN9hWBRwuOcAs-1zcoSbyh-OUwJ6ZtjRcNOUr_m8qzrBgDdOeQUtmN6wFoDqmZH31I4TlBrqmsITU2A02onlfs0JPs-W3Irg8=@emersion.fr>
In-Reply-To
<CAMAFT9W0wrwVDogMVsHcrGqytSO4-3Yno4EmT2jgG4eDSvD1uw@mail.gmail.com> (view parent)
Sender timestamp
1549836750
DKIM signature
pass
Download raw message
On Sunday, February 10, 2019 11:10 PM, Elias Naur <mail@eliasnaur.com> wrote:
> Yes. Sorry for leaving that information out, it's my first time with
> git send-mail.

No problem :)

> > Maintainers can choose whether they want to include go.sum or not in
> > their repos. I often choose not to.
>
> go.sum exists in the repository, and the additions was added automatically by
> go build.

Oh okay, then yeah it makes sense to update it.