This thread contains a patchset. You're looking at the original emails,
but you may wish to use the patch review UI.
Review patch
3
2
[PATCH gddo v2] Fix onhashchange event listener
---
This uses addEventListener instead of setting the onhashchange property.
gddo-server/assets/site.js | 6 +++ ---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/gddo-server/assets/site.js b/gddo-server/assets/site.js
index 7beb5f1..d761d3b 100644
--- a/gddo-server/assets/site.js
+++ b/gddo-server/assets/site.js
@@ -239,12 +239,12 @@ document.onkeydown = function(e) {
return true
}
- function onhashchanged() {
+ function onhashchange() {
// open selected example
var hash = window.location.hash
if (hash.startsWith("#example-")) {
document.querySelector(hash).parentElement.setAttribute("open", "")
}
}
- window.onhashchanged = onhashchanged
- onhashchanged()
+ window.addEventListener("hashchange", onhashchange)
+ onhashchange()
--
2.30.0
> +function onhashchange() {
I don't really like that name. What about handleHashChange?
On Thu Jan 14, 2021 at 2:47 PM EST, Alexey wrote:
> > +function onhashchange() {
>
> I don't really like that name. What about handleHashChange?
NACK, go to bikeshedding jail.
Thanks!
To git@git.sr.ht:~sircmpwn/gddo
9c1d4f5..0b015cb master -> master