~sircmpwn/public-inbox

git-send-email.io: Remove exclamation points from echo commands v1 PROPOSED

Brendon Smith: 1
 Remove exclamation points from echo commands

 1 files changed, 3 insertions(+), 3 deletions(-)
Double quotes do not escape exclamation points in Bash by default (when history expansion is enabled and POSIX mode is not enabled).
https://www.gnu.org/software/bash/manual/html_node/Double-Quotes.html
Ugh, fucking bash. Thanks, I'll get this patch applied once I'm home
from FOSDEM travels.
Thanks!

To git.sr.ht:~sircmpwn/git-send-email.io
   44c0c60..1824da9  master -> master
Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~sircmpwn/public-inbox/patches/9730/mbox | git am -3
Learn more about email & git

[PATCH git-send-email.io] Remove exclamation points from echo commands Export this patch

The echo commands in step 3 may not work as expected for users who are
not aware of Bash history expansion.

Bash adds a dquote continuation line:
echo "I'm about to try git send-email!" >your-name

Omitting the bang works:
echo "I'm about to try git send-email" >your-name

Also works without double quotes:
echo I\'m about to try git send-email! >your-name
echo Im about to try git send-email! >your-name
echo 'Im about to try git send-email!' >your-name

Signed-off-by: Brendon Smith <br3ndonland@protonmail.com>
---
 index.html | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/index.html b/index.html
index af9c3c0..543dac3 100644
--- a/index.html
+++ b/index.html
@@ -154,7 +154,7 @@
              <li>
                <strong>Make your changes</strong>. Let's add a file with your
                progress so far:
                <pre>echo "I'm about to try git send-email!" &gt;your-name</pre>
                <pre>echo "I'm about to try git send-email" &gt;your-name</pre>
                <div style="margin: 0.5rem 0">
                  Be sure to change <code>your-name</code> to your own!
                </div>
@@ -167,7 +167,7 @@
                  rel="noopener"
                >Pro Git</a> book if you don't know how to do this.
                <pre>git add your-name
<!--              -->git commit -m "Demonstrate that I can use git send-email!"</pre>
<!--              -->git commit -m "Demonstrate that I can use git send-email"</pre>
              </li>
              <li>
                <strong>Send the patch</strong>! If you check out the
@@ -275,7 +275,7 @@
                  the differences since the first patch on the next line. It
                  should look something like this:
                </p>
                <pre>Subject: [PATCH v2] Demonstrate that I can use git send-email!
                <pre>Subject: [PATCH v2] Demonstrate that I can use git send-email

<!--              -->---
<!--              -->This fixes the issues raised from the first patch.
-- 
2.25.0
...but, the commands are quoted?
View this thread in the archives