~sircmpwn/sr.ht-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
6 3

[PATCH man.sr.ht] Move username out of wiki title

Details
Message ID
<1bdb6f9310e73bf08826.1613107721@freefall>
DKIM signature
pass
Download raw message
Patch: +7 -4
piggyback the header-extension style used in git.sr.ht for repository
descriptions in order to move wiki owner out of the wiki title while
keeping it visually adjacent

Intended to address sr.ht-discuss: Wiki "Public" page
<C96YNX5WZPFC.1CU197QUTFYCI@taiga>

diff --git a/mansrht/templates/content.html b/mansrht/templates/content.html
--- a/mansrht/templates/content.html
+++ b/mansrht/templates/content.html
@@ -12,11 +12,7 @@
  <div class="container">
    <ul class="nav nav-tabs">
      <h2>
        {% if wiki and not is_root %}
          {{wiki.owner.canonical_name}}/<wbr>{{wiki.name}}/<wbr>{{title}}
        {% else %}
          {{title}}
        {% endif %}
      </h2>
      <li class="nav-item">
        <a class="nav-link active" href="/">article</a>
@@ -36,6 +32,13 @@
    </ul>
  </div>
</div>
{% if wiki and not is_root %}
<div class="header-extension">
  <div class="container">
    {{wiki.owner.canonical_name}}/<wbr>{{wiki.name}}
  </div>
</div>          
{% endif %}
{% endif %}
<div class="container">
  <div class="content">

[man.sr.ht/patches] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<C97B0BCSBBW6.209JQTI30W5HD@cirno2>
In-Reply-To
<1bdb6f9310e73bf08826.1613107721@freefall> (view parent)
DKIM signature
missing
Download raw message
man.sr.ht/patches: SUCCESS in 2m1s

[Move username out of wiki title][0] from [Nolan Prescott][1]

[0]: https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/20236
[1]: mail@nprescott.com

✓ #423806 SUCCESS man.sr.ht/patches/archlinux.yml https://builds.sr.ht/~sircmpwn/job/423806
✓ #423807 SUCCESS man.sr.ht/patches/debian.yml    https://builds.sr.ht/~sircmpwn/job/423807
✓ #423805 SUCCESS man.sr.ht/patches/alpine.yml    https://builds.sr.ht/~sircmpwn/job/423805
Details
Message ID
<C97L22WUDK40.E76QDB5ZT63J@taiga>
In-Reply-To
<1bdb6f9310e73bf08826.1613107721@freefall> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
This is a nice solution! Can you update it so that the username is a
link to their man.sr.ht profile page (i.e. man.sr.ht/~sircmpwn)?

[PATCH V2 man.sr.ht] Move username out of wiki title

Details
Message ID
<b9525dd758d2a5133ad8.1613140925@halcyon.my.domain>
In-Reply-To
<C97L22WUDK40.E76QDB5ZT63J@taiga> (view parent)
DKIM signature
pass
Download raw message
Patch: +8 -4
piggyback the header-extension style used in git.sr.ht for repository
descriptions in order to move wiki owner out of the wiki title while
keeping it visually adjacent. Link username to wiki profile page.

Intended to address sr.ht-discuss: Wiki "Public" page
<C96YNX5WZPFC.1CU197QUTFYCI@taiga>

diff --git a/mansrht/templates/content.html b/mansrht/templates/content.html
--- a/mansrht/templates/content.html
+++ b/mansrht/templates/content.html
@@ -12,11 +12,7 @@
  <div class="container">
    <ul class="nav nav-tabs">
      <h2>
        {% if wiki and not is_root %}
          {{wiki.owner.canonical_name}}/<wbr>{{wiki.name}}/<wbr>{{title}}
        {% else %}
          {{title}}
        {% endif %}
      </h2>
      <li class="nav-item">
        <a class="nav-link active" href="/">article</a>
@@ -36,6 +32,14 @@
    </ul>
  </div>
</div>
{% if wiki and not is_root %}
<div class="header-extension">
  <div class="container">
    <a href="/{{wiki.owner.canonical_name}}">{{wiki.owner.canonical_name}}</a>
    /<wbr>{{wiki.name}}
  </div>
</div>
{% endif %}
{% endif %}
<div class="container">
  <div class="content">

Re: [PATCH V2 man.sr.ht] Move username out of wiki title

Details
Message ID
<C97MQTIWUNLF.20RLHY64OQMYI@taiga>
In-Reply-To
<b9525dd758d2a5133ad8.1613140925@halcyon.my.domain> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
Please use url_for instead of hard-coding the URL format.

[PATCH V3 man.sr.ht] Move username out of wiki title

Details
Message ID
<dc6eeb8b0a7cb5477f76.1613141734@halcyon.my.domain>
In-Reply-To
<C97MQTIWUNLF.20RLHY64OQMYI@taiga> (view parent)
DKIM signature
pass
Download raw message
Patch: +9 -4
piggyback the header-extension style used in git.sr.ht for repository
descriptions in order to move wiki owner out of the wiki title while
keeping it visually adjacent. Link username to wiki profile page.

Intended to address sr.ht-discuss: Wiki "Public" page
<C96YNX5WZPFC.1CU197QUTFYCI@taiga>

diff --git a/mansrht/templates/content.html b/mansrht/templates/content.html
--- a/mansrht/templates/content.html
+++ b/mansrht/templates/content.html
@@ -12,11 +12,7 @@
  <div class="container">
    <ul class="nav nav-tabs">
      <h2>
        {% if wiki and not is_root %}
          {{wiki.owner.canonical_name}}/<wbr>{{wiki.name}}/<wbr>{{title}}
        {% else %}
          {{title}}
        {% endif %}
      </h2>
      <li class="nav-item">
        <a class="nav-link active" href="/">article</a>
@@ -36,6 +32,15 @@
    </ul>
  </div>
</div>
{% if wiki and not is_root %}
<div class="header-extension">
  <div class="container">
    <a href="{{ url_for("public.user_index",
             username=wiki.owner.username) }}">{{wiki.owner.canonical_name}}</a>
    /<wbr>{{wiki.name}}
  </div>
</div>
{% endif %}
{% endif %}
<div class="container">
  <div class="content">

Re: [PATCH V3 man.sr.ht] Move username out of wiki title

Details
Message ID
<C97OKAYMLXAF.MCR968OB1GF@taiga>
In-Reply-To
<dc6eeb8b0a7cb5477f76.1613141734@halcyon.my.domain> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
Made a minor change to get rid of the space between the username and the
slash. Thanks!

To git@git.sr.ht:~sircmpwn/man.sr.ht
   0662e81..9457763  master -> master
Reply to thread Export thread (mbox)