~sircmpwn/sr.ht-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 2

[PATCH meta.sr.ht] RFC6749 4.2.1 compliance workaround

Details
Message ID
<20191011191149.147017-1-jrb@expunge.us>
DKIM signature
missing
Download raw message
Patch: +4 -0
RFC6749 defines a `scope` parameter in the authorize GET request
but meta.sr.ht currently implements and documents a `scopes` parameter.
As a workaround, this commit checks for `scope` if `scopes` is found to
be empty. https://todo.sr.ht/~sircmpwn/meta.sr.ht/128

Signed-off-by: Jared Baldridge <jrb@expunge.us>
---
 metasrht/blueprints/oauth_exchange.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/metasrht/blueprints/oauth_exchange.py b/metasrht/blueprints/oauth_exchange.py
index 8aeeee4..46151bb 100644
--- a/metasrht/blueprints/oauth_exchange.py
+++ b/metasrht/blueprints/oauth_exchange.py
@@ -54,6 +54,10 @@ def oauth_authorize_GET():
    state = request.args.get('state')
    client = OAuthClient.query.filter(OAuthClient.client_id == client_id).first()

    # workaround to enable rfc6749 interoperability
    if not scopes:
        scopes = request.args.get('scope')

    if not client_id or not client:
        return render_template("oauth-error.html",
                details="Unknown client ID"), 400
-- 
2.23.0
Details
Message ID
<kRMiHwiHY62iDttDSXGWhjv9_GKv7QT9cNnzzs0pe1p8-kdPHdOOqDRcc-0EqvOEv_2EKTtT7In9P_aQcTzSTCCVEEa99eR5KQrDyUr9htA=@partin.io>
In-Reply-To
<20191011191149.147017-1-jrb@expunge.us> (view parent)
DKIM signature
missing
Download raw message
Jared,

Your email ended up in my spam folder fyi. Not sure if it actually
hit the developers inboxes.

Here is a link that could help you with your domain. https://protonmail.com/support/knowledge-base/email-has-failed-its-domains-authentication-requirements-warning/
Details
Message ID
<BXQDX563BNUT.1DS8X8K2D7015@homura>
In-Reply-To
<kRMiHwiHY62iDttDSXGWhjv9_GKv7QT9cNnzzs0pe1p8-kdPHdOOqDRcc-0EqvOEv_2EKTtT7In9P_aQcTzSTCCVEEa99eR5KQrDyUr9htA=@partin.io> (view parent)
DKIM signature
missing
Download raw message
I got it, it's in my review queue.
Details
Message ID
<BXR1CZGWZSM6.2D45N73BCKSXC@homura>
In-Reply-To
<20191011191149.147017-1-jrb@expunge.us> (view parent)
DKIM signature
missing
Download raw message
Thanks!

To git.sr.ht:~sircmpwn/meta.sr.ht
   8053176..5b4ddcb  master -> master
 * [new tag]         0.35.3 -> 0.35.3
Review patch Export thread (mbox)