~sircmpwn/sr.ht-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
4 3

[PATCH lists.sr.ht] updates new tracker error message to specify that trackers must start with a letter

Details
Message ID
<20200524012252.ngvpuop2lskslk2t@tarteausucre.boxen.tm-t.ca>
DKIM signature
missing
Download raw message
---
 todosrht/types/tracker.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/todosrht/types/tracker.py b/todosrht/types/tracker.py
index 3a673b4..06a52fe 100644
--- a/todosrht/types/tracker.py
+++ b/todosrht/types/tracker.py
@@ -70,7 +70,7 @@ class Tracker(Base):
                 "Must be between 1 and 255 characters",
                 field="name")
         valid.expect(not valid.ok or name_re.match(name),
-                "Only alphanumeric characters or ._-",
+                "Only alphanumeric characters or ._-, must begin with a
letter",
                 field="name")
         valid.expect(not desc or len(desc) < 4096,
                 "Must be less than 4096 characters",
-- 
2.27.0.rc0
Details
Message ID
<20200524012630.6hvzdqk5lulxal5f@tarteausucre.boxen.tm-t.ca>
In-Reply-To
<20200524012252.ngvpuop2lskslk2t@tarteausucre.boxen.tm-t.ca> (view parent)
DKIM signature
missing
Download raw message
Patch: +1 -1
---
 todosrht/types/tracker.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/todosrht/types/tracker.py b/todosrht/types/tracker.py
index 3a673b4..06a52fe 100644
--- a/todosrht/types/tracker.py
+++ b/todosrht/types/tracker.py
@@ -70,7 +70,7 @@ class Tracker(Base):
                "Must be between 1 and 255 characters",
                field="name")
        valid.expect(not valid.ok or name_re.match(name),
                "Only alphanumeric characters or ._-",
                "Only alphanumeric characters or ._-, must begin with a letter",
                field="name")
        valid.expect(not desc or len(desc) < 4096,
                "Must be less than 4096 characters",
-- 
2.27.0.rc0
Details
Message ID
<C2ZVHKND6YQV.3DN0PJWN41300@homura>
In-Reply-To
<20200524012630.6hvzdqk5lulxal5f@tarteausucre.boxen.tm-t.ca> (view parent)
DKIM signature
pass
Download raw message
This is an invalid patch. Please send your patches only using git
send-email or the git.sr.ht patchset preparation UI:

https://git-send-email.io
Details
Message ID
<20200525143256.akklbujxvf7t4zcp@tarteausucre.boxen.tm-t.ca>
In-Reply-To
<C2ZVHKND6YQV.3DN0PJWN41300@homura> (view parent)
DKIM signature
missing
Download raw message
Hello,

On Mon, May 25, 2020 at 10:16:33AM -0400, Drew DeVault wrote:
> This is an invalid patch. Please send your patches only using git
> send-email or the git.sr.ht patchset preparation UI:
> 
> https://git-send-email.io

The first patch was invalid, the second one I sent in reply 3 minutes
later appears to be valid, at least as per the lists.sr.ht web
interface.

Taowa

-- 
Taowa Munene-Tardif
taowa.ca
Montréal
Details
Message ID
<C2ZVUU3AEK8B.1TA198JOED5VG@homura>
In-Reply-To
<20200525143256.akklbujxvf7t4zcp@tarteausucre.boxen.tm-t.ca> (view parent)
DKIM signature
pass
Download raw message
The lists.sr.ht web interface is more tolerant of invalid patches than
git is, because it doesn't actually have to try to apply them to a
real-world repo. Use git send-email.
Review patch Export thread (mbox)