~sircmpwn/sr.ht-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH lists.sr.ht] Always show 'Reply to thread' button

Steven Guikal
Details
Message ID
<20201113191845.1499333-1-void@fluix.dev>
DKIM signature
fail
Download raw message
Patch: +0 -8 DKIM signature: fail
---
 listssrht/templates/thread.html | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/listssrht/templates/thread.html b/listssrht/templates/thread.html
index c02482b..54ecf35 100644
--- a/listssrht/templates/thread.html
+++ b/listssrht/templates/thread.html
@@ -184,18 +184,10 @@
          owner_name=owner.canonical_name, list_name=ml.name,
          patchset_id=thread.patchset_id) }}"
        >Review patch {{icon('caret-right')}}</a>
        {% if current_user %}
        <a class="btn btn-default btn-block"
          href="{{reply_to(thread.replies[-1] if thread.replies else thread)}}"
        >Reply to thread {{icon('caret-right')}}</a>
        {% endif %}
        {% else %}
        {% if current_user %}
        <a class="btn btn-primary btn-block"
          href="{{reply_to(thread.replies[-1] if thread.replies else thread)}}"
        >Reply to thread {{icon('caret-right')}}</a>
        {% endif %}
        {% endif %}
        <a class="btn btn-default btn-block" href="{{ url_for('archives.mbox',
          owner_name=owner.canonical_name, list_name=ml.name,
          message_id=thread.message_id) }}"
-- 
2.29.2

[lists.sr.ht/patches] build success

builds.sr.ht
Details
Message ID
<C72DOROIUTY7.1IB9MVLU9L73C@cirno>
In-Reply-To
<20201113191845.1499333-1-void@fluix.dev> (view parent)
DKIM signature
missing
Download raw message
lists.sr.ht/patches: SUCCESS in 2m28s

[Always show 'Reply to thread' button][0] from [Steven Guikal][1]

[0]: https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/14984
[1]: mailto:void@fluix.dev

✓ #341664 SUCCESS lists.sr.ht/patches/debian.yml    https://builds.sr.ht/~sircmpwn/job/341664
✓ #341662 SUCCESS lists.sr.ht/patches/alpine.yml    https://builds.sr.ht/~sircmpwn/job/341662
✓ #341663 SUCCESS lists.sr.ht/patches/archlinux.yml https://builds.sr.ht/~sircmpwn/job/341663
Details
Message ID
<C742BN2QQO25.12LS3NVCF1VUP@taiga>
In-Reply-To
<C72DOROIUTY7.1IB9MVLU9L73C@cirno> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
Thanks!

To git.sr.ht:~sircmpwn/lists.sr.ht
   f830361..e07674f  master -> master

There are some other issues with the reply button if you're interested
in investigating:

- It takes the subject from the last email, not the thread subject
- It does not Cc everyone, just the sender of the last reply
- It doesn't respect Reply-To
- It should be added to the patchset review page as well as the archives
Reply to thread Export thread (mbox)