~sircmpwn/sr.ht-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 2

[PATCH core.sr.ht v2] Dark theme alert info box colour change.

Details
Message ID
<20201218202652.2735-1-jack@jpgleeson.com>
DKIM signature
pass
Download raw message
Patch: +5 -2
Variables have been scoped to dark as per previous email.

I find the contrast between the links and the alert-info
boxes to be low, making them hard to read on some of my
screens. This is a change to make them a bit more readable
but feedback from others to confirm it's not just me
having a hard time reading it would be useful. 

---
 srht/scss/dark.scss | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/srht/scss/dark.scss b/srht/scss/dark.scss
index 8749fc4..b207d66 100644
--- a/srht/scss/dark.scss
+++ b/srht/scss/dark.scss
@@ -1,7 +1,10 @@

$primary-dark: darken($primary, 10);
$success-dark: #2bb34b;
$danger-dark: #ff3e3e;
$muted-dark: $gray-400;
$alert-info-background-dark: #a6bcbf;
$alert-info-border-dark: #78828a;
$link-dark: lighten($primary, 10);
$darker: darken($gray-900, 6);
$border: $gray-700;
@@ -52,8 +55,8 @@ code {
}

.alert-info {
  background-color: darken(#d1ecf1, 20);
  border-color: darken(#bee5eb, 10);
  background-color: $alert-info-background-dark;
  border-color: $alert-info-border-dark;
  color: $black;

  a:not(.btn) {
-- 
2.29.2
Details
Message ID
<C7WU18CD0FOF.2ULONQ9KB6FUA@taiga>
In-Reply-To
<20201218202652.2735-1-jack@jpgleeson.com> (view parent)
DKIM signature
pass
Download raw message
Do you have a before/after screenshot to share?
Details
Message ID
<99e76c32e1a09ad2403262558cbc7606@jpgleeson.com>
In-Reply-To
<C7WU18CD0FOF.2ULONQ9KB6FUA@taiga> (view parent)
DKIM signature
pass
Download raw message
Screenshots below. I find the contrast between the two colours
a bit too close for easy reading. Maybe a better solution is
to change the link colour in the alert-info box, but this seemed
a smaller change in terms of consistency with everything else.

Original: https://jpgleeson.com/content/srht-darktheme-originalcrop.png
Patched: https://jpgleeson.com/content/srht-darktheme-modifiedcrop.png

December 19, 2020 9:30 AM, "Drew DeVault" <sir@cmpwn.com> wrote:

> Do you have a before/after screenshot to share?
Details
Message ID
<C7WYVQQBL66A.3AK9USRG5KN1T@taiga>
In-Reply-To
<99e76c32e1a09ad2403262558cbc7606@jpgleeson.com> (view parent)
DKIM signature
pass
Download raw message
Hm, not fond of the color being this muted. The purpose of the info box
is to catch your attention. I think it would be better to mute it only
slightly, and to change the link color to improve the contrast.
Reply to thread Export thread (mbox)