~sircmpwn/sr.ht-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH metrics.sr.ht] align annotations with actual thresholds

Details
Message ID
<20210114021531.28855-1-bor.groseljsimic@telemach.net>
DKIM signature
missing
Download raw message
Patch: +3 -3
---
The values in descriptions weren't matching the values in rules.

Would it perhaps be desirable to abuse one of the optional fields prometheus
allows in rule definitions as "variables" to store those often repeated
thresholds and avoid such problems in the future?

 node_rules.yml | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/node_rules.yml b/node_rules.yml
index 05fbc7e..972aef0 100644
--- a/node_rules.yml
+++ b/node_rules.yml
@@ -93,14 +93,14 @@ groups:
      > 5)
    << : *brief
    annotations:
      summary: "Instance {{ $labels.instance }} >2 MiB/s disk I/O"
      summary: "Instance {{ $labels.instance }} >5 MiB/s disk I/O"
  - alert: Sustained high disk I/O
    expr: *disk_gt_5mibsec
    << : *sustained
    annotations:
      summary: "Instance {{ $labels.instance }} sustained >2 MiB/s disk I/O"
      summary: "Instance {{ $labels.instance }} sustained >5 MiB/s disk I/O"
  - alert: Prolonged high disk I/O
    expr: *disk_gt_5mibsec
    << : *prolonged
    annotations:
      summary: "Instance {{ $labels.instance }} prolonged >2 MiB/s disk I/O"
      summary: "Instance {{ $labels.instance }} prolonged >5 MiB/s disk I/O"
-- 
2.30.0
Details
Message ID
<C8IWH51PTGXU.2M40HZG9JQWAK@taiga>
In-Reply-To
<20210114021531.28855-1-bor.groseljsimic@telemach.net> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
Thanks!

To git@git.sr.ht:~sircmpwn/metrics.sr.ht
   82e4020..3b1aef8  master -> master
Reply to thread Export thread (mbox)