Hello,
This patchset updates some `install_requires` lists in various `setup.py`s,
enough to get the initial `run.py` working
Somewhat related:
https://lists.sr.ht/~sircmpwn/sr.ht-discuss/%3C20210307163630.enwbghloptrkrm4o%40zillasnegl%3E
As the officially recommended way of getting a sourcehut installation is
through one of the 3 distro's package manager, these changes are mostly for
devs hacking onto the app and wrangling dependencies using pip :)
I chose to have the packages that depend on the core celery webhook just depend
on celery as it makes the dependency resolution a bit easier, as
`srht[webhooks]` won't automatically resolve. But I do understand if the
alternative is preferred
Also the `emailthreads` dependency in `lists.sr.ht` won't work until
https://github.com/emersion/python-emailthreads/issues/6
is resolved
--
Marco Sirabella
[PATCH core.sr.ht 1/2] Pin sqlalchemy < 1.4.0 for sqlalchemy-utils
The real fix is for sqlalchemy-utils to pin this properly,
but looks like [they aren't for some
reason](https://github.com/kvesteri/sqlalchemy-utils/issues/505) And
would rather just fix the problems.
This is unneccessary when
<https://github.com/kvesteri/sqlalchemy-utils/pull/506> is merged, and
pestering them might be the better fix.
---
setup.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/setup.py b/setup.py
index 55a3870..e5f4ede 100755
--- a/setup.py+++ b/setup.py
@@ -28,7 +28,7 @@ setup(
install_requires = [
'flask',
'humanize',
- 'sqlalchemy',+ 'sqlalchemy<1.4.0', 'sqlalchemy-utils',
'psycopg2',
'markdown',
--
2.26.3
On Thu Apr 1, 2021 at 10:23 PM EDT, Marco Sirabella wrote:
> Hello,>> This patchset updates some `install_requires` lists in various> `setup.py`s,> enough to get the initial `run.py` working>> Somewhat related:> https://lists.sr.ht/~sircmpwn/sr.ht-discuss/%3C20210307163630.enwbghloptrkrm4o%40zillasnegl%3E>> As the officially recommended way of getting a sourcehut installation> is through one of the 3 distro's package manager, these changes are> mostly for devs hacking onto the app and wrangling dependencies using> pip :)
Those devs are not supported. No thanks.
Technically celery is a dependency of the core's celery webhook, but I
opt for just marking it as a dependency here instead of an
extras_requires in the core because the dev workflow is probably `pip
install core.sr.ht && pip install scm.sr.ht` and that won't catch an
`srht[webhooks-celery]` dependency
---
setup.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/setup.py b/setup.py
index c113b78..51eb378 100755
--- a/setup.py+++ b/setup.py
@@ -21,7 +21,7 @@ setup(
author = 'Ludovic Chabant',
author_email = 'ludovic@chabant.com',
url = 'https://git.sr.ht/~sircmpwn/scm.sr.ht',
- install_requires = ['srht'],+ install_requires = ['srht', 'celery'], license = 'AGPL-3.0',
package_data={
'scmsrht': [
--
2.26.3
Technically a dependency of core.sr.ht celery webhooks, but we use those
here and they are an optional dependcy of core, so...
---
setup.py | 1 +
1 file changed, 1 insertion(+)
diff --git a/setup.py b/setup.py
index a282b28..c49c4cf 100755
--- a/setup.py+++ b/setup.py
@@ -34,6 +34,7 @@ setup(
install_requires = [
'pystache',
'srht',
+ 'celery', ],
license = 'AGPL-3.0',
package_data={
--
2.26.3
On 4/1/21 10:25 PM, Drew DeVault wrote:
> On Thu Apr 1, 2021 at 10:23 PM EDT, Marco Sirabella wrote:>> Hello,>>>> This patchset updates some `install_requires` lists in various>> `setup.py`s,>> enough to get the initial `run.py` working>>>> Somewhat related:>> https://lists.sr.ht/~sircmpwn/sr.ht-discuss/%3C20210307163630.enwbghloptrkrm4o%40zillasnegl%3E>>>> As the officially recommended way of getting a sourcehut installation>> is through one of the 3 distro's package manager, these changes are>> mostly for devs hacking onto the app and wrangling dependencies using>> pip :)> > Those devs are not supported. No thanks.
It also represents a way for distro packagers to follow along with the
requirements, which might be easier than cribbing from another distro
packaging recipe with an unfamiliar format.
And, particularly, some distro package managers actually look at
install_requires and add them to the package too.
For example, Fedora does this. Documented here:
https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatically_generated_dependencies
--
Eli Schwartz
Arch Linux Bug Wrangler and Trusted User
Eli Schwartz a écrit :
> On 4/1/21 10:25 PM, Drew DeVault wrote:>> On Thu Apr 1, 2021 at 10:23 PM EDT, Marco Sirabella wrote:>>> Hello,>>>>>> This patchset updates some `install_requires` lists in various>>> `setup.py`s,>>> enough to get the initial `run.py` working>>>>>> Somewhat related:>>> https://lists.sr.ht/~sircmpwn/sr.ht-discuss/%3C20210307163630.enwbghloptrkrm4o%40zillasnegl%3E>>>>>> As the officially recommended way of getting a sourcehut installation>>> is through one of the 3 distro's package manager, these changes are>>> mostly for devs hacking onto the app and wrangling dependencies using>>> pip :)>>>> Those devs are not supported. No thanks.> > It also represents a way for distro packagers to follow along with the> requirements, which might be easier than cribbing from another distro> packaging recipe with an unfamiliar format.
True.
> And, particularly, some distro package managers actually look at> install_requires and add them to the package too.> > For example, Fedora does this. Documented here:> https://docs.fedoraproject.org/en-US/packaging-guidelines/Python/#_automatically_generated_dependencies
Debian does this as well:
https://manpages.debian.org/buster/dh-python/dh_python3.1.en.html#dependencies
On 02/04/2021 04.33, Drew DeVault wrote:
> NACK to all of these patches. We don't support this installation method.> Don't waste your time.
Then why bother with having an install_requires section at all if it's
incomplete and obviously not necessary?
Okay, I've installed some, but not all of these. The issue with
sqlalchemy-utils is an upstream problem, not ours, and the celery
dependency is part of core.sr.ht, not the downstream.s
On Fri, Apr 02, 2021 at 10:15:02AM +0200, minus wrote:
> On 02/04/2021 04.33, Drew DeVault wrote:> > NACK to all of these patches. We don't support this installation method.> > Don't waste your time.> > Then why bother with having an install_requires section at all if it's> incomplete and obviously not necessary?
Good question