~sircmpwn/sr.ht-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
4 3

[PATCH core.sr.ht] css: Add bottom margin to <pre>

Details
Message ID
<20210608120409.70531-1-sol@solfisher.com>
DKIM signature
pass
Download raw message
Patch: +1 -1
---
Follow-up from conversation on IRC -- codeblocks at ends of pages didn't
have a margin

 srht/scss/base.scss | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/srht/scss/base.scss b/srht/scss/base.scss
index 5b1811e..9129f8c 100644
--- a/srht/scss/base.scss
+++ b/srht/scss/base.scss
@@ -42,7 +42,7 @@ body {
  }
}

p {
p, pre {
  margin-bottom: 0.5rem;
}

-- 
2.32.0

[core.sr.ht/patches] build success

builds.sr.ht
Details
Message ID
<CBY83FTIGGPS.32X5G39CFIZQM@cirno2>
In-Reply-To
<20210608120409.70531-1-sol@solfisher.com> (view parent)
DKIM signature
missing
Download raw message
core.sr.ht/patches: SUCCESS in 3m16s

[css: Add bottom margin to <pre>][0] from [Sol Fisher Romanoff][1]

[0]: https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/23207
[1]: mailto:sol@solfisher.com

✓ #521740 SUCCESS core.sr.ht/patches/alpine.yml    https://builds.sr.ht/~sircmpwn/job/521740
✓ #521742 SUCCESS core.sr.ht/patches/debian.yml    https://builds.sr.ht/~sircmpwn/job/521742
✓ #521741 SUCCESS core.sr.ht/patches/archlinux.yml https://builds.sr.ht/~sircmpwn/job/521741
Details
Message ID
<CBYEJF23HI7G.19JABU5WTL1NQ@taiga>
In-Reply-To
<20210608120409.70531-1-sol@solfisher.com> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
Can you share a link or two to pages which would benefit from this
change?
Details
Message ID
<CBYEN2PQ71JD.3GMTG9IILWU3A@neophyte>
In-Reply-To
<CBYEJF23HI7G.19JABU5WTL1NQ@taiga> (view parent)
DKIM signature
pass
Download raw message
On Tue Jun 8, 2021 at 8:10 PM IDT, Drew DeVault wrote:
> Can you share a link or two to pages which would benefit from this
> change?

Yes, here is a test repo I've made:
https://git.sr.ht/~sfr/test

As you can see, the README in the main page looks fine,
but look in the file from the tree:
https://git.sr.ht/~sfr/test/tree/master/item/README.md
and the codeblock doesn't have a margin, sticking to the bottom.

This is an extreme example: the codeblock is closer to other elementss
from the bottom than from the top:
https://git.sr.ht/~yerinalexey/ctest/tree/main/item/README.md
See how the regular lines "sticks" to the end of the codeblock.
Details
Message ID
<CBYEWYVGTRX7.22INSUYTYD5KM@taiga>
In-Reply-To
<CBYEN2PQ71JD.3GMTG9IILWU3A@neophyte> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
Thanks!

To git@git.sr.ht:~sircmpwn/core.sr.ht
   fd6fa10..60a70a8  master -> master
Reply to thread Export thread (mbox)