~sircmpwn/sr.ht-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
3 3

[PATCH git.sr.ht 1/2] Revert "Change markup for diff insert/delete lines"

Details
Message ID
<20221201215320.615535-1-ch@bitfehler.net>
DKIM signature
missing
Download raw message
Patch: +2 -3
This reverts commit b75d2f0e03317c9b37dfdb702f3a959555309890.

This commit has some issues:

- It uses <ins>/<del> not for the content that was actually
  added/removed (i.e. the diff), but for the line stats. I don't think
  that helps accessibility, it might actually make it worse.
- It adds some CSS to apply text decoration to <ins>/<del>, but only
  inside the `diff` class. However, the elements never occur inside the
  `diff` class (see first item). The CSS is never used.
- Instead, the place where it was used (line stats) got unintended text
  decoration applied, causing a follow-up commit which fixed this the
  wrong way, causing yet more issues (fixed in next commit).

I think the one place where it would make sense to apply <ins>/<del> is
the diff itself, but that might be a more serious operation.
---
 gitsrht/templates/utils.html | 4 ++--
 scss/main.scss               | 1 -
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/gitsrht/templates/utils.html b/gitsrht/templates/utils.html
index 9a9637d..14d6c75 100644
--- a/gitsrht/templates/utils.html
+++ b/gitsrht/templates/utils.html
@@ -195,8 +195,8 @@ instead.
  target="_blank"
  {% endif %}
 >{{patch.delta.new_file.raw_path.decode('utf-8', 'replace')}}</a>{#
 #} <span class="pull-right"><ins class="text-success">+{{patch.line_stats[1]}}</ins>{#
 #} <del class="text-danger">-{{patch.line_stats[2]}}</del></span>{%
 #} <span class="pull-right"><span class="text-success">+{{patch.line_stats[1]}}</span>{#
 #} <span class="text-danger">-{{patch.line_stats[2]}}</span></span>{%
    if patch.delta.old_file.mode != patch.delta.new_file.mode %}{#
  #}{#
  #}{% endif %}</pre>
diff --git a/scss/main.scss b/scss/main.scss
index 31f5317..a5530ee 100644
--- a/scss/main.scss
+++ b/scss/main.scss
@@ -273,7 +273,6 @@ del {
}

.diff {
  ins, del,
  .lineno {
    text-decoration: none;
  }
-- 
2.38.1

[PATCH git.sr.ht 2/2] Revert "Fix text-decoration for <del> tag"

Details
Message ID
<20221201215320.615535-2-ch@bitfehler.net>
In-Reply-To
<20221201215320.615535-1-ch@bitfehler.net> (view parent)
DKIM signature
missing
Download raw message
Patch: +0 -4
This reverts commit 390e609e533048007e73b8cd587d1923989e7373.

The approach was too heavy-handed. It messes with folks who use <del> in
their README. The commit that introduced the issue that the reverted
commit was trying to address has itself been reverted.
---
 scss/main.scss | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/scss/main.scss b/scss/main.scss
index a5530ee..c9120d1 100644
--- a/scss/main.scss
+++ b/scss/main.scss
@@ -26,10 +26,6 @@ dt {
  overflow-wrap: break-word;
}

del {
  text-decoration: underline;
}

.licenses {
  text-align: right;
  a {
-- 
2.38.1

[git.sr.ht/patches] build failed

builds.sr.ht <builds@sr.ht>
Details
Message ID
<COQTFSIFXBEL.3AX2II7K908JW@cirno2>
In-Reply-To
<20221201215320.615535-2-ch@bitfehler.net> (view parent)
DKIM signature
missing
Download raw message
git.sr.ht/patches: FAILED in 4m9s

[Revert "Change markup for diff insert/delete lines"][0] from [Conrad Hoffmann][1]

[0]: https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/37276
[1]: ch@bitfehler.net

✗ #895903 FAILED  git.sr.ht/patches/debian.yml    https://builds.sr.ht/~sircmpwn/job/895903
✓ #895902 SUCCESS git.sr.ht/patches/archlinux.yml https://builds.sr.ht/~sircmpwn/job/895902
✓ #895901 SUCCESS git.sr.ht/patches/alpine.yml    https://builds.sr.ht/~sircmpwn/job/895901

Re: [PATCH git.sr.ht 2/2] Revert "Fix text-decoration for <del> tag"

Details
Message ID
<CP5SBVQOE4BS.1EDNRQZP1CHRV@taiga>
In-Reply-To
<20221201215320.615535-2-ch@bitfehler.net> (view parent)
DKIM signature
missing
Download raw message
Thanks!

To git@git.sr.ht:~sircmpwn/git.sr.ht
   03671cc..be2eda0  master -> master
Reply to thread Export thread (mbox)