~sircmpwn/sr.ht-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
5 4

[PATCH builds.sr.ht] contrib/submit_image_build: Make builds public

Details
Message ID
<20230701164230.1901057-1-hi@taavi.wtf>
DKIM signature
missing
Download raw message
Patch: +1 -1
This patch restores the status quo for the refresh jobs being visible
at https://builds.sr.ht/~sircmpwn/refresh from before builds.sr.ht
gained the concept of job visibility.
---
 contrib/submit_image_build | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/contrib/submit_image_build b/contrib/submit_image_build
index e3d7137..93b01c2 100755
--- a/contrib/submit_image_build
+++ b/contrib/submit_image_build
@@ -46,7 +46,7 @@ if from_image:
url = f"{url}/query"
query = """
mutation SubmitBuild($manifest: String!, $note: String!, $tags: [String!]!) {
    submit(manifest: $manifest, note: $note, tags: $tags) {
    submit(manifest: $manifest, note: $note, tags: $tags, visibility: PUBLIC) {
        id
    }
}
-- 
2.40.1
Details
Message ID
<tEcIFoE68pmm6YDM64FjR9P4gp8IRzJLwuQqFeOnjXoKzgOQSUeFWnBs3jOe3BOHsSGZF6wCpwVwszFGWTxh8eqwILkKR0W6gJ5O7w_K2UA=@emersion.fr>
In-Reply-To
<20230701164230.1901057-1-hi@taavi.wtf> (view parent)
DKIM signature
missing
Download raw message
Have you tested this mutation? (Could be done with the GraphQL playground
for instance, or hut(1).)

I would've expected "PUBLIC" to require double-quotes, but maybe I'm
wrong.

[builds.sr.ht/patches] build failed

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CTQZM3Z9J1WA.DTJ797ALDSQC@cirno2>
In-Reply-To
<20230701164230.1901057-1-hi@taavi.wtf> (view parent)
DKIM signature
missing
Download raw message
builds.sr.ht/patches: FAILED in 5m10s

[contrib/submit_image_build: Make builds public][0] from [Taavi Väänänen][1]

[0]: https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/42314
[1]: hi@taavi.wtf

✓ #1016755 SUCCESS builds.sr.ht/patches/debian.yml    https://builds.sr.ht/~sircmpwn/job/1016755
✗ #1016754 FAILED  builds.sr.ht/patches/archlinux.yml https://builds.sr.ht/~sircmpwn/job/1016754
✓ #1016753 SUCCESS builds.sr.ht/patches/alpine.yml    https://builds.sr.ht/~sircmpwn/job/1016753
Details
Message ID
<7f990020-7e09-d874-d166-b2532c371b6b@taavi.wtf>
In-Reply-To
<tEcIFoE68pmm6YDM64FjR9P4gp8IRzJLwuQqFeOnjXoKzgOQSUeFWnBs3jOe3BOHsSGZF6wCpwVwszFGWTxh8eqwILkKR0W6gJ5O7w_K2UA=@emersion.fr> (view parent)
DKIM signature
missing
Download raw message
On 7/1/23 19:44, Simon Ser wrote:
> Have you tested this mutation? (Could be done with the GraphQL playground
> for instance, or hut(1).)
> 
> I would've expected "PUBLIC" to require double-quotes, but maybe I'm
> wrong.

I did test it using the playground. It's a GraphQL enum, and apparently 
that means you can't use quotes around it, and you get an error saying 
"Enum cannot represent non-enum value" if you try.
Details
Message ID
<pciAqyR2Ds5e9wy4ejYa8kc2cPq5NCG0cK2kkuOPkz1J1VNcx2o3EGriWcz3IJYFa7EzdpwsuWz4nTCImyvKvW5Lv04oBouRqp5gyr__VUw=@emersion.fr>
In-Reply-To
<7f990020-7e09-d874-d166-b2532c371b6b@taavi.wtf> (view parent)
DKIM signature
missing
Download raw message
On Saturday, July 1st, 2023 at 18:50, Taavi Väänänen <hi@taavi.wtf> wrote:

> On 7/1/23 19:44, Simon Ser wrote:
> 
> > Have you tested this mutation? (Could be done with the GraphQL playground
> > for instance, or hut(1).)
> > 
> > I would've expected "PUBLIC" to require double-quotes, but maybe I'm
> > wrong.
> 
> I did test it using the playground. It's a GraphQL enum, and apparently
> that means you can't use quotes around it, and you get an error saying
> "Enum cannot represent non-enum value" if you try.

I see, makes sense!

The patch looks good to me.
Details
Message ID
<CTUY0HOAGL86.36BFDS0DYNEQ3@taiga>
In-Reply-To
<20230701164230.1901057-1-hi@taavi.wtf> (view parent)
DKIM signature
missing
Download raw message
Thanks!

To git@git.sr.ht:~sircmpwn/builds.sr.ht
   0be575e..5295e2c  master -> master
Reply to thread Export thread (mbox)