~sircmpwn/sr.ht-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH builds.sr.ht] images/control: Clarify error messages

Details
Message ID
<20230706103851.103948-1-hi@taavi.wtf>
DKIM signature
missing
Download raw message
Patch: +2 -2
Changes the error message for trying to run a non-existent architecture
to mention that it's specifically the architecture that's missing and
not the specific image (which is checked at the very start of the file).

The error message for a non-existent image is clarified a bit too, to
make it more clear what's wrong in the manifest, instead of how the
runner is detecting that.
---
 images/control | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/images/control b/images/control
index 4091ebd..b468e37 100755
--- a/images/control
+++ b/images/control
@@ -13,7 +13,7 @@ shift 2

if [ ! -d $self/$base ]
then
	printf "Not a directory '%s'\n" "$base" >&2
	printf "Image '%s' does not exist\n" "$base" >&2
	exit 1
fi

@@ -135,7 +135,7 @@ cmd_boot() {
	fi
	if [ ! -e "$self/$base/$arch/root.img.qcow2" ]
	then
		printf "Unknown base image '%s'\n" "$base" >&2
		printf "Image '%s' is not available for arch '%s'\n" "$base" "$arch" >&2
		exit 1
	fi

-- 
2.40.1

[builds.sr.ht/patches] build failed

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CTV10IY5N3CG.19966K8GQ8DTP@cirno2>
In-Reply-To
<20230706103851.103948-1-hi@taavi.wtf> (view parent)
DKIM signature
missing
Download raw message
builds.sr.ht/patches: FAILED in 4m59s

[images/control: Clarify error messages][0] from [Taavi Väänänen][1]

[0]: https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/42445
[1]: hi@taavi.wtf

✗ #1019581 FAILED  builds.sr.ht/patches/archlinux.yml https://builds.sr.ht/~sircmpwn/job/1019581
✓ #1019580 SUCCESS builds.sr.ht/patches/alpine.yml    https://builds.sr.ht/~sircmpwn/job/1019580
✓ #1019582 SUCCESS builds.sr.ht/patches/debian.yml    https://builds.sr.ht/~sircmpwn/job/1019582
Details
Message ID
<CTVRR3KJT2LR.GGW8X9ZTTKXU@taiga>
In-Reply-To
<20230706103851.103948-1-hi@taavi.wtf> (view parent)
DKIM signature
missing
Download raw message
Thanks!

To git@git.sr.ht:~sircmpwn/builds.sr.ht
   979c15e..b7cf38a  master -> master
Reply to thread Export thread (mbox)