~sircmpwn/sr.ht-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
5 3

[PATCH sourcehut.org v2 0/3] various link styling changes

Details
Message ID
<20230915083033.77059-1-jackson@jacksonchen666.com>
DKIM signature
missing
Download raw message
I noticed that links were not underlined, which isn't great for
accessibility and isn't consistent with sourcehut services.

I've attempted to match the style of links on sourcehut services to the
sourcehut.org website in this patch set.

v2 of this patch set contains the requested changes:
- Latest blog post now has underline on hover
- Navigation links not underlined except on hover

Jackson Chen (3):
  do not override text decoration on links
  make button links not underlined
  no underline on blog post and navigation links

 assets/main.scss   | 11 ++++++++++-
 layouts/index.html |  2 +-
 2 files changed, 11 insertions(+), 2 deletions(-)

-- 
2.42.0

[PATCH sourcehut.org v2 1/3] do not override text decoration on links

Details
Message ID
<20230915083033.77059-2-jackson@jacksonchen666.com>
In-Reply-To
<20230915083033.77059-1-jackson@jacksonchen666.com> (view parent)
DKIM signature
missing
Download raw message
Patch: +0 -1
links can be hard to distinguish when there is no color, so don't
prevent link underlining.
---
 assets/main.scss | 1 -
 1 file changed, 1 deletion(-)

diff --git a/assets/main.scss b/assets/main.scss
index 7e5bbc6..e6afe80 100644
--- a/assets/main.scss
+++ b/assets/main.scss
@@ -187,7 +187,6 @@ form {

a {
  color: $primary;
  text-decoration: none;

  &:hover {
    color: darken($primary, 15);
-- 
2.42.0

[PATCH sourcehut.org v2 2/3] make button links not underlined

Details
Message ID
<20230915083033.77059-3-jackson@jacksonchen666.com>
In-Reply-To
<20230915083033.77059-1-jackson@jacksonchen666.com> (view parent)
DKIM signature
missing
Download raw message
Patch: +5 -0
matching sourcehut
---
 assets/main.scss | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/assets/main.scss b/assets/main.scss
index e6afe80..0c61afe 100644
--- a/assets/main.scss
+++ b/assets/main.scss
@@ -242,6 +242,11 @@ a {
    display: block;
    text-align: center;
  }

  $parent: &;
  @at-root a#{&} {
    text-decoration: none;
  }
}

.form-group {
-- 
2.42.0

[PATCH sourcehut.org v2 3/3] no underline on blog post and navigation links

Details
Message ID
<20230915083033.77059-4-jackson@jacksonchen666.com>
In-Reply-To
<20230915083033.77059-1-jackson@jacksonchen666.com> (view parent)
DKIM signature
missing
Download raw message
Patch: +6 -1
except when hovering

place link underline exceptions above a:hover, required because of how
CSS applies and overrides styles. reduces duplicated styles.
---
 assets/main.scss   | 5 +++++
 layouts/index.html | 2 +-
 2 files changed, 6 insertions(+), 1 deletion(-)

diff --git a/assets/main.scss b/assets/main.scss
index 0c61afe..adbf9a7 100644
--- a/assets/main.scss
+++ b/assets/main.scss
@@ -185,6 +185,11 @@ form {
  margin-bottom: 1rem;
}

// Place this above a:hover styles for that to take effect
a.blog-link, nav a {
  text-decoration: none;
}

a {
  color: $primary;

diff --git a/layouts/index.html b/layouts/index.html
index 0a8111b..012ef4b 100644
--- a/layouts/index.html
+++ b/layouts/index.html
@@ -18,7 +18,7 @@
          </div>
          <div class="content">
            <h1>
              <a href="{{.Permalink}}">
              <a href="{{.Permalink}}" class="blog-link">
                <small>
                  From the blog
                  <span class="icon">
-- 
2.42.0

[sourcehut.org/patches/.build.yml] build failed

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CVJCNRG8NJEH.1BZ09XTSGEE1Q@cirno2>
In-Reply-To
<20230915083033.77059-4-jackson@jacksonchen666.com> (view parent)
DKIM signature
missing
Download raw message
sourcehut.org/patches/.build.yml: FAILED in 21s

[various link styling changes][0] v2 from [Jackson Chen][1]

[0]: https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/44737
[1]: jackson@jacksonchen666.com

✗ #1057956 FAILED sourcehut.org/patches/.build.yml https://builds.sr.ht/~sircmpwn/job/1057956
Details
Message ID
<CVJD2T3BX0FP.2G7J6GN5T4RGU@taiga>
In-Reply-To
<20230915083033.77059-1-jackson@jacksonchen666.com> (view parent)
DKIM signature
missing
Download raw message
Thanks!

To git@git.sr.ht:~sircmpwn/sourcehut.org
   07233f9..ee6f2e2  master -> master
Reply to thread Export thread (mbox)