~sircmpwn/sr.ht-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
14 5

[PATCH builds.sr.ht] ubuntu/noble starts development

Details
Message ID
<20231031024057.6445-1-lhw@lunacd.com>
DKIM signature
missing
Download raw message
Patch: +11 -4
---
 contrib/crontab               | 8 +++++---
 images/ubuntu/24.04           | 1 +
 images/ubuntu/next            | 2 +-
 images/ubuntu/noble/functions | 1 +
 images/ubuntu/noble/genimg    | 3 +++
 5 files changed, 11 insertions(+), 4 deletions(-)
 create mode 120000 images/ubuntu/24.04
 create mode 120000 images/ubuntu/noble/functions
 create mode 100755 images/ubuntu/noble/genimg

diff --git a/contrib/crontab b/contrib/crontab
index b94c695..98155cf 100644
--- a/contrib/crontab
+++ b/contrib/crontab
@@ -3,7 +3,7 @@
30 20 * * * chronic /usr/local/bin/submit_image_build -n "Daily scheduled build image refresh" alpine/edge
 0 21 * * * chronic /usr/local/bin/submit_image_build -n "Daily scheduled build image refresh" -a amd64 debian/unstable
30 21 * * * chronic /usr/local/bin/submit_image_build -n "Daily scheduled build image refresh" nixos/unstable
 0 22 * * * chronic /usr/local/bin/submit_image_build -n "Daily scheduled build image refresh" -a amd64 ubuntu/next
 0 22 * * * chronic /usr/local/bin/submit_image_build -n "Daily scheduled build image refresh" -a amd64 ubuntu/24.04
30 22 * * * chronic /usr/local/bin/submit_image_build -n "Daily scheduled build image refresh" fedora/rawhide
 0 23 * * * chronic /usr/local/bin/submit_image_build -n "Daily scheduled build image refresh" guix

@@ -17,14 +17,16 @@
30 19 * * 2 chronic /usr/local/bin/submit_image_build -n "Weekly scheduled build image refresh" -a amd64 debian/testing
 0 19 * * 3 chronic /usr/local/bin/submit_image_build -n "Weekly scheduled build image refresh" -a amd64 freebsd/12.x
30 19 * * 3 chronic /usr/local/bin/submit_image_build -n "Weekly scheduled build image refresh" -a x86_64 rockylinux/8
 0 19 * * 4 chronic /usr/local/bin/submit_image_build -n "Weekly scheduled build image refresh" -a amd64 ubuntu/lts
 0 19 * * 4 chronic /usr/local/bin/submit_image_build -n "Weekly scheduled build image refresh" -a amd64 ubuntu/22.04
30 19 * * 4 chronic /usr/local/bin/submit_image_build -n "Weekly scheduled build image refresh" alpine/latest
 0 19 * * 5 chronic /usr/local/bin/submit_image_build -n "Weekly scheduled build image refresh" -a amd64 freebsd/13.x
30 19 * * 5 chronic /usr/local/bin/submit_image_build -n "Weekly scheduled build image refresh" -a amd64 ubuntu/23.04
30 19 * * 5 chronic /usr/local/bin/submit_image_build -n "Weekly scheduled build image refresh" -a amd64 ubuntu/23.10
 0 19 * * 6 chronic /usr/local/bin/submit_image_build -n "Weekly scheduled build image refresh" -a amd64 openbsd/latest
30 19 * * 6 chronic /usr/local/bin/submit_image_build -n "Weekly scheduled build image refresh" -a x86_64 rockylinux/9

# Monthly
0 18 1 * * chronic /usr/local/bin/submit_image_build -n "Monthly scheduled build image refresh" -a amd64 ubuntu/oldlts
0 18 1 * * chronic /usr/local/bin/submit_image_build -n "Monthly scheduled build image refresh" -a amd64 ubuntu/20.04
30 18 1 * * chronic /usr/local/bin/submit_image_build -n "Monthly scheduled build image refresh" fedora/37
0 18 2 * * chronic /usr/local/bin/submit_image_build -n "Monthly scheduled build image refresh" alpine/older
0 18 3 * * chronic /usr/local/bin/submit_image_build -n "Monthly scheduled build image refresh" alpine/oldest
diff --git a/images/ubuntu/24.04 b/images/ubuntu/24.04
new file mode 120000
index 0000000..c44ffaf
--- /dev/null
+++ b/images/ubuntu/24.04
@@ -0,0 +1 @@
noble
\ No newline at end of file
diff --git a/images/ubuntu/next b/images/ubuntu/next
index ec22642..c44ffaf 120000
--- a/images/ubuntu/next
+++ b/images/ubuntu/next
@@ -1 +1 @@
mantic
\ No newline at end of file
noble
\ No newline at end of file
diff --git a/images/ubuntu/noble/functions b/images/ubuntu/noble/functions
new file mode 120000
index 0000000..c0b5bcc
--- /dev/null
+++ b/images/ubuntu/noble/functions
@@ -0,0 +1 @@
../functions
\ No newline at end of file
diff --git a/images/ubuntu/noble/genimg b/images/ubuntu/noble/genimg
new file mode 100755
index 0000000..7be89d1
--- /dev/null
+++ b/images/ubuntu/noble/genimg
@@ -0,0 +1,3 @@
#!/bin/sh -eux
export release=noble
exec ../genimg "$@"
-- 
2.39.2

[builds.sr.ht/patches] build failed

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CWMA40W8KBNB.36K42QW7HK85M@cirno2>
In-Reply-To
<20231031024057.6445-1-lhw@lunacd.com> (view parent)
DKIM signature
missing
Download raw message
builds.sr.ht/patches: FAILED in 4m53s

[ubuntu/noble starts development][0] from [Haowen Liu][1]

[0]: https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/46264
[1]: lhw@lunacd.com

✗ #1085430 FAILED  builds.sr.ht/patches/archlinux.yml https://builds.sr.ht/~sircmpwn/job/1085430
✓ #1085429 SUCCESS builds.sr.ht/patches/alpine.yml    https://builds.sr.ht/~sircmpwn/job/1085429
✓ #1085431 SUCCESS builds.sr.ht/patches/debian.yml    https://builds.sr.ht/~sircmpwn/job/1085431
Details
Message ID
<63aa6690-041a-4275-b760-634d44c3efad@bitfehler.net>
In-Reply-To
<20231031024057.6445-1-lhw@lunacd.com> (view parent)
DKIM signature
missing
Download raw message
I tried to apply this, but the image does not build (on /lts, at least?):

https://builds.sr.ht/~bitfehler/job/1104224
Details
Message ID
<491b77b0-e352-4a1c-a96d-ce166f1ce7e1@lunacd.com>
In-Reply-To
<63aa6690-041a-4275-b760-634d44c3efad@bitfehler.net> (view parent)
DKIM signature
missing
Download raw message
On 11/30/2023 8:33 AM, Conrad Hoffmann wrote:
> I tried to apply this, but the image does not build (on /lts, at least?):
> 
> https://builds.sr.ht/~bitfehler/job/1104224

That is correct. But that is unfortunately not caused by the genimg 
script. The current ubuntu/next is also failing [1].

This is caused by the ubuntu/lts image being VERY VERY out of date. 
Inserting `sudo apt update && sudo apt upgrade -y` fixed the issue. This 
is a repro [2] on the current ubuntu/next 4 months ago. It's fair to say 
that ubuntu/lts hasn't been updated, for some unknown reason, for at 
least 4 months now.

[1] https://builds.sr.ht/~sircmpwn/job/1104523
[2] https://builds.sr.ht/~haowenl/job/1028259
Details
Message ID
<eab26a47-453f-4b4a-b14e-bce905729e62@bitfehler.net>
In-Reply-To
<491b77b0-e352-4a1c-a96d-ce166f1ce7e1@lunacd.com> (view parent)
DKIM signature
missing
Download raw message
On 12/1/23 01:02, Haowen Liu wrote:
> On 11/30/2023 8:33 AM, Conrad Hoffmann wrote:
>> I tried to apply this, but the image does not build (on /lts, at least?):
>>
>> https://builds.sr.ht/~bitfehler/job/1104224
> 
> That is correct. But that is unfortunately not caused by the genimg 
> script. The current ubuntu/next is also failing [1].
> 
> This is caused by the ubuntu/lts image being VERY VERY out of date. 
> Inserting `sudo apt update && sudo apt upgrade -y` fixed the issue. This 
> is a repro [2] on the current ubuntu/next 4 months ago. It's fair to say 
> that ubuntu/lts hasn't been updated, for some unknown reason, for at 
> least 4 months now.

QQ: have you been getting any emails about build failures for these? 
According to the Ubuntu build.yml, you shoud get those
Details
Message ID
<CXFIPJWECNGV.2JG4YI5LMOVY3@taiga>
In-Reply-To
<491b77b0-e352-4a1c-a96d-ce166f1ce7e1@lunacd.com> (view parent)
DKIM signature
missing
Download raw message
Is there a plan to bring Ubuntu builds back in good working order?
Details
Message ID
<3568580b-c5c0-41e7-9bc7-2bb6a8790025@bitfehler.net>
In-Reply-To
<491b77b0-e352-4a1c-a96d-ce166f1ce7e1@lunacd.com> (view parent)
DKIM signature
missing
Download raw message
On 12/1/23 01:02, Haowen Liu wrote:
> This is caused by the ubuntu/lts image being VERY VERY out of date. 
> Inserting `sudo apt update && sudo apt upgrade -y` fixed the issue. This 
> is a repro [2] on the current ubuntu/next 4 months ago. It's fair to say 
> that ubuntu/lts hasn't been updated, for some unknown reason, for at 
> least 4 months now.

This would be quite strange. All recent builds for the LTS image have 
succeeded [1]. I also verified that the image deployed to the build 
worker is indeed only a few days old.

I am not quite sure what to make of this?

[1] https://builds.sr.ht/~sircmpwn/refresh/ubuntu/lts

Cheers,
Conrad
Details
Message ID
<ce21d0e1-2087-4524-b238-c17ff68d9d72@lunacd.com>
In-Reply-To
<3568580b-c5c0-41e7-9bc7-2bb6a8790025@bitfehler.net> (view parent)
DKIM signature
missing
Download raw message
On 12/4/2023 10:06 AM, Conrad Hoffmann wrote:
> I am not quite sure what to make of this?
> 
> [1] https://builds.sr.ht/~sircmpwn/refresh/ubuntu/lts
> 
> Cheers,
> Conrad

Yup, not sure either. One of the following three is happening:

1. genimg is building an outdated image to begin with
2. The updated version image is not properly deployed
3. The properly deployed version did not get used by builds.sr.ht

Maybe start by checking the deployed image timestamp?

Haowen
Details
Message ID
<c921c5aa-f1dd-4cc4-9a8e-71ae2dfc25e9@taavi.wtf>
In-Reply-To
<ce21d0e1-2087-4524-b238-c17ff68d9d72@lunacd.com> (view parent)
DKIM signature
missing
Download raw message
When building a new jammy image, debootstrap by default only includes 
the main jammy APT suite, and then the genimg script then adds extra 
suites (for example jammy-security and jammy-updates) to the 
sources.list file later to be used for any future apt commands.

However to build a mantic image on jammy, you need the distro-info-data 
package from jammy-updates[0]. debootstrap pulls down the 
distro-info-data package from the jammy suite as a part of the base 
image for some reason, and the manual `sudo apt update && sudo apt 
upgrade -y` you tried pulls the newer version from `jammy-updates` which 
explains why it fixes the build.

[0]: https://packages.ubuntu.com/source/jammy-updates/distro-info-data

Taavi
Details
Message ID
<613ff92c-d2ec-4e8e-a2b6-e2d701036d1c@lunacd.com>
In-Reply-To
<c921c5aa-f1dd-4cc4-9a8e-71ae2dfc25e9@taavi.wtf> (view parent)
DKIM signature
missing
Download raw message
On 12/4/2023 9:44 PM, Taavi Väänänen wrote:
> When building a new jammy image, debootstrap by default only includes 
> the main jammy APT suite, and then the genimg script then adds extra 
> suites (for example jammy-security and jammy-updates) to the 
> sources.list file later to be used for any future apt commands.
> 
> However to build a mantic image on jammy, you need the distro-info-data 
> package from jammy-updates[0]. debootstrap pulls down the 
> distro-info-data package from the jammy suite as a part of the base 
> image for some reason, and the manual `sudo apt update && sudo apt 
> upgrade -y` you tried pulls the newer version from `jammy-updates` which 
> explains why it fixes the build.
> 
> [0]: https://packages.ubuntu.com/source/jammy-updates/distro-info-data
> 
> Taavi

Thanks for explaining this! Do you know how to make deboostrap add 
jammy-security and jammy-updates to the list of repos it pulls from? Or 
should I just run apt-get upgrade at the end of genimg?

Haowen
Details
Message ID
<80ef192b-7145-4e06-b193-aa2619f02fab@taavi.wtf>
In-Reply-To
<613ff92c-d2ec-4e8e-a2b6-e2d701036d1c@lunacd.com> (view parent)
DKIM signature
missing
Download raw message
According to its manpage, you can pass --extra-suites= to specify a 
comma-separated list of additional suites. I've never tried it though, 
and I don't ever recall seeing the same issue on the Debian image.

Taavi
Details
Message ID
<8fb81bd4-0bad-4f17-9d9d-8d34bc079ce4@lunacd.com>
In-Reply-To
<80ef192b-7145-4e06-b193-aa2619f02fab@taavi.wtf> (view parent)
DKIM signature
missing
Download raw message
On 12/4/2023 9:50 PM, Taavi Väänänen wrote:
> According to its manpage, you can pass --extra-suites= to specify a 
> comma-separated list of additional suites. I've never tried it though, 
> and I don't ever recall seeing the same issue on the Debian image.
> 
> Taavi

Thank you! I checked how genimg is doing things and it seems it 
currently overrides the source list after bootstrapping. I chose the 
route of less disruptive change and simply added an extra upgrade in the 
genimg process.

See [1].

[1] https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/47411.

Haowen
Details
Message ID
<f5b20d33-620b-4910-8c8c-7ddedaf89af8@lunacd.com>
In-Reply-To
<63aa6690-041a-4275-b760-634d44c3efad@bitfehler.net> (view parent)
DKIM signature
pass
Download raw message
Hi Conrad,

Could you please check this patch once again? With this [1] commit, this 
patch should be good to go.

Haowen

[1] 
https://git.sr.ht/~sircmpwn/builds.sr.ht/commit/1b21add920b56007b8597db667e858a403a88b1d
Details
Message ID
<8b99b041-735e-4d89-ae28-cfa03c59737e@bitfehler.net>
In-Reply-To
<f5b20d33-620b-4910-8c8c-7ddedaf89af8@lunacd.com> (view parent)
DKIM signature
pass
Download raw message
On 1/21/24 04:40, Haowen Liu wrote:
> Could you please check this patch once again?

Can you please re-submit the patch and include a link to a successful 
build log?

Cheers,
Conrad
Details
Message ID
<544ebaaa-4729-4bce-96c4-c58b76e52e41@lunacd.com>
In-Reply-To
<8b99b041-735e-4d89-ae28-cfa03c59737e@bitfehler.net> (view parent)
DKIM signature
pass
Download raw message
On 1/23/2024 6:19 AM, Conrad Hoffmann wrote:>
> Can you please re-submit the patch and include a link to a successful 
> build log?
> 
> Cheers,
> Conrad

[1] and [2]. I'll send another pair tomorrow or the day after to remove 
23.04.

Haowen

[1] https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/48877
[2] https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/48876
Reply to thread Export thread (mbox)