I saw a [post on the mailing list][1] where a user had some trouble
using the Debian + Eleventy example due to it referencing an old
version of Debian that is no longer supported by builds.st.ht.
This patchset improves the example in several ways:
- Image changed from stale debian/buster to evergreen debian/stable
- Node.js version updated to new LTS and a non-distro-specific repo
- Updated env var to disable the npm progress bar
[1]: https://lists.sr.ht/~sircmpwn/sr.ht-discuss/%3CCAPxX4hCqQFqymCCdOy70gEiwQojAALO7iVjPujybp0433QZ3TA%40mail.gmail.com%3E
Noelle Leigh (3):
eleventy.yml: Switch to debian/stable
eleventy.yml: Switch to distroless nodesource, v20
eleventy.yml: Disable progress bar correctly
eleventy.yml | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
--
2.30.2
[PATCH pages.sr.ht-examples 1/3] eleventy.yml: Switch to debian/stable
Is the third-party repository actually necessary? Current Debian stable
ships with Node 18 and NPM 9 which is well within Eleventy's required
Node 14 or newer.
Taavi
Re: [PATCH pages.sr.ht-examples 2/3] eleventy.yml: Switch to distroless nodesource, v20
On Thu, Nov 9, 2023, at 7:48 AM, Taavi Väänänen wrote:
> Is the third-party repository actually necessary? Current Debian> stable ships with Node 18 and NPM 9 which is well within Eleventy's> required Node 14 or newer.>> Taavi
Technically it's not necessary, but it does provide a helpful example
for how to install a newer version from a third-party repo, which is not
intuitive for users who are unfamiliar with gpg.
Re: [PATCH pages.sr.ht-examples 2/3] eleventy.yml: Switch to distroless nodesource, v20
On Fri Nov 10, 2023 at 1:57 AM CET, Noelle Leigh wrote:
> Technically it's not necessary, but it does provide a helpful example> for how to install a newer version from a third-party repo, which is not> intuitive for users who are unfamiliar with gpg.
The examples should focus on one thing at time, it's better to
demonstrate one idea than two.
Re: [PATCH pages.sr.ht-examples 2/3] eleventy.yml: Switch to distroless nodesource, v20
On Fri, Nov 10, 2023, at 2:38 AM, Drew DeVault wrote:
> The examples should focus on one thing at time, it's better to> demonstrate one idea than two.
I tried modifying the sample manifest to install [nodejs][1] and
[npm][2] from the built-in repos, and it ended up installing waaaay more
than I expected ([see build log][3]). It included stuff like eslint and
handlebars for whatever reason.
Is the lack of a third-party repo worth the trade off for a vastly over-
specified package installation process?
[1]: https://packages.debian.org/stable/nodejs
[2]: https://packages.debian.org/stable/npm
[3]: https://builds.sr.ht/~noelle/job/1091748
Re: [PATCH pages.sr.ht-examples 2/3] eleventy.yml: Switch to distroless nodesource, v20
On 11/10/23 14:39, Noelle Leigh wrote:
> On Fri, Nov 10, 2023, at 2:38 AM, Drew DeVault wrote:>> The examples should focus on one thing at time, it's better to>> demonstrate one idea than two.> > I tried modifying the sample manifest to install [nodejs][1] and> [npm][2] from the built-in repos, and it ended up installing waaaay more> than I expected ([see build log][3]). It included stuff like eslint and> handlebars for whatever reason.> > Is the lack of a third-party repo worth the trade off for a vastly over-> specified package installation process?
I would say yes, just to keep this simple. This is just Debian being
Debian, and one could argue over whether we should install manifest
packages with `--no-install-recommends`/`--no-install-suggests` or
something, but for the purpose of demonstration, this is fine.
That said, while I am not the authority on anything NodeJS, I could see
there being value in having a _separate_ example explaining how to
install it from third-party repos for those who need/want that.
Cheers,
Conrad
Re: [PATCH pages.sr.ht-examples 2/3] eleventy.yml: Switch to distroless nodesource, v20
On Thu, Nov 16, 2023, at 5:33 AM, Conrad Hoffmann wrote:
> I would say yes, just to keep this simple. This is just Debian being > Debian, and one could argue over whether we should install manifest > packages with `--no-install-recommends`/`--no-install-suggests` or > something, but for the purpose of demonstration, this is fine.
New patch series submitted [1].
[1]: https://lists.sr.ht/~sircmpwn/sr.ht-dev/%3C20231121115815.3938-1-noelle_leigh%40fastmail.com%3E