~sircmpwn/sr.ht-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH git.sr.ht] Fix generation of Blame url

Details
Message ID
<20240414223150.30146-3-jonne@yyny.dev>
DKIM signature
pass
Download raw message
Patch: +1 -1
The Blame URLs returned by `url_for` currently return e.g. `b'master'`
for the ref component, breaking the "Blame" tab. Example:

https://git.sr.ht/~yyny/test/blame/b%27master%27/README.md

This patch fixes that.

---
 gitsrht/blueprints/repo.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gitsrht/blueprints/repo.py b/gitsrht/blueprints/repo.py
index 11418c3..3b7c10a 100644
--- a/gitsrht/blueprints/repo.py
+++ b/gitsrht/blueprints/repo.py
@@ -416,7 +416,7 @@ def weld_hunks(blame):
        yield last

@repo.route("/<owner>/<repo>/blame/<path:ref>", defaults={"path": ""})
@repo.route("/<owner>/<repo>/blame/<ref>/<path:path>")
@repo.route("/<owner>/<repo>/blame/<path:ref>/<path:path>")
def blame(owner, repo, ref, path):
    owner, repo = get_repo_or_redir(owner, repo)
    with GitRepository(repo.path) as git_repo:
-- 
2.44.0

[git.sr.ht/patches/alpine.yml] build failed

builds.sr.ht <builds@sr.ht>
Details
Message ID
<D0K7M7XNFT5B.2B2DKDSQC195@fra01>
In-Reply-To
<20240414223150.30146-3-jonne@yyny.dev> (view parent)
DKIM signature
missing
Download raw message
git.sr.ht/patches/alpine.yml: FAILED in 1m17s

[Fix generation of Blame url][0] from [Jonne Ransijn][1]

[0]: https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/51020
[1]: jonne@yyny.dev

✗ #1195943 FAILED git.sr.ht/patches/alpine.yml https://builds.sr.ht/~sircmpwn/job/1195943
Details
Message ID
<D0O0ZKGV8B7H.119SGOCU89JPA@cmpwn.com>
In-Reply-To
<20240414223150.30146-3-jonne@yyny.dev> (view parent)
DKIM signature
pass
Download raw message
Thanks!

To git@git.sr.ht:~sircmpwn/git.sr.ht
   7144962..2b4c2f9  master -> master
Reply to thread Export thread (mbox)