~sircmpwn/sr.ht-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
2 2

[PATCH core.sr.ht] fix scripts disappearing after pyproject.toml conversion

Details
Message ID
<20240528012051.3375408-1-eschwartz93@gmail.com>
DKIM signature
pass
Download raw message
Patch: +5 -0
In commit 1fbbcabb7c23516cf08f9581c5ea4876aa89326d, setup.py was reduced
to a stub loader for the pyproject.toml static metadata.

Without getting into whether it makes sense to programmatically vs.
statically define e.g. package_data, the scripts= argument to setup()
was never included in pyproject.toml and was removed from setup.py; this
broke the resulting installed package.

Restore this information.

Signed-off-by: Eli Schwartz <eschwartz93@gmail.com>
---
 pyproject.toml | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/pyproject.toml b/pyproject.toml
index 3005b8d..00b4718 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -51,6 +51,11 @@ packages = [
    "srht.templates",
    "srht.webhook",
]
script-files = [
    "srht-update-profiles",
    "srht-migrate",
    "srht-keygen",
]
[tool.setuptools.package-data]
"srht" = ['Makefile', 'minify-css.js']
"srht.templates" = ['*.html']
-- 
2.44.1

[core.sr.ht/patches/alpine.yml] build success

builds.sr.ht <builds@sr.ht>
Details
Message ID
<D1KVU18UBA2S.26WW9ZJK0RLRE@fra01>
In-Reply-To
<20240528012051.3375408-1-eschwartz93@gmail.com> (view parent)
DKIM signature
missing
Download raw message
core.sr.ht/patches/alpine.yml: SUCCESS in 43s

[fix scripts disappearing after pyproject.toml conversion][0] from [Eli Schwartz][1]

[0]: https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/52976
[1]: eschwartz93@gmail.com

✓ #1233076 SUCCESS core.sr.ht/patches/alpine.yml https://builds.sr.ht/~sircmpwn/job/1233076
Details
Message ID
<D1L4G9WV7SE8.16GJTWVD0T6NW@bitfehler.net>
In-Reply-To
<20240528012051.3375408-1-eschwartz93@gmail.com> (view parent)
DKIM signature
pass
Download raw message
Thanks! (I tagged a new release)

to git@git.sr.ht:~sircmpwn/core.sr.ht
  24f65f7..34213d6  master -> master
Reply to thread Export thread (mbox)