~sircmpwn/sr.ht-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
5 3

[PATCH git.sr.ht] Replace meta.sr.ht's /oauth endpoint with /oauth2 in comments

Details
Message ID
<87wn4mlkuv.fsf@florness.com>
DKIM signature
missing
Download raw message
Patch: +2 -2
While there is a link to /oauth2 on the /oauth page, landing on /oauth2 right
away makes it obvious to server admins that /oauth2 is where they should be.

Discussion: <https://lists.sr.ht/~sircmpwn/sr.ht-discuss/%3C877cwnhpni.fsf%40florness.com%3E>
Signed-off-by: David Florness <david@florness.com>
---
 config.example.ini            | 2 +-
 gitsrht/default_query.graphql | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/config.example.ini b/config.example.ini
index 7c645e8..beface9 100644
--- a/config.example.ini
+++ b/config.example.ini
@@ -112,7 +112,7 @@ webhooks=redis://localhost:6379/1
post-update-script=/usr/bin/gitsrht-update-hook
#
# git.sr.ht's OAuth client ID and secret for meta.sr.ht
# Register your client at meta.example.org/oauth
# Register your client at meta.example.org/oauth2
oauth-client-id=CHANGEME
oauth-client-secret=CHANGEME
#
diff --git a/gitsrht/default_query.graphql b/gitsrht/default_query.graphql
index 0ddaa07..630fffb 100644
--- a/gitsrht/default_query.graphql
+++ b/gitsrht/default_query.graphql
@@ -30,7 +30,7 @@ query {

  # On this page, you have been automatically authorized to make API requests
  # with your sr.ht login cookie. If you wish to make GraphQL requests outside
  # of the browser, create a personal access token at https://meta.sr.ht/oauth
  # of the browser, create a personal access token at https://meta.sr.ht/oauth2
  #
  # curl \
  #     -H Authorization:"Bearer <your oauth token>" \
-- 
2.39.1

[git.sr.ht/patches] build failed

builds.sr.ht <builds@sr.ht>
Details
Message ID
<CQGUNIH89M5X.1PPLZQ8GZZTH9@cirno2>
In-Reply-To
<87wn4mlkuv.fsf@florness.com> (view parent)
DKIM signature
missing
Download raw message
git.sr.ht/patches: FAILED in 4m31s

[Replace meta.sr.ht's /oauth endpoint with /oauth2 in comments][0] from [David Florness][1]

[0]: https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/38949
[1]: david@florness.com

✓ #939350 SUCCESS git.sr.ht/patches/debian.yml    https://builds.sr.ht/~sircmpwn/job/939350
✓ #939348 SUCCESS git.sr.ht/patches/alpine.yml    https://builds.sr.ht/~sircmpwn/job/939348
✗ #939349 FAILED  git.sr.ht/patches/archlinux.yml https://builds.sr.ht/~sircmpwn/job/939349
Details
Message ID
<87sffalkmc.fsf@florness.com>
In-Reply-To
<87wn4mlkuv.fsf@florness.com> (view parent)
DKIM signature
missing
Download raw message
BTW, there are other repos that could also get a patch for this, but I
was gonna hold off on sending those until this one gets accepted (in
case folks disagree with the motivation).

-- 
David
Details
Message ID
<CQI5AI6ADO6H.39CESCLMYYHS5@taiga>
In-Reply-To
<87wn4mlkuv.fsf@florness.com> (view parent)
DKIM signature
missing
Download raw message
I think we can skip this for config.example.ini; we mostly use internal
auth now and will be remove these config details in the foreseeable
future in any case.

default_query.graphql should be updated, though, and the update looks
good for all affected services if you'd like to prepare patches for
them.

[PATCH git.sr.ht v2] Replace meta.sr.ht's /oauth endpoint with /oauth2 in comment

Details
Message ID
<87a61anwus.fsf@florness.com>
In-Reply-To
<87wn4mlkuv.fsf@florness.com> (view parent)
DKIM signature
missing
Download raw message
Patch: +1 -1
While there is a link to /oauth2 on the /oauth page, landing on /oauth2 right
away makes it obvious to server admins that /oauth2 is where they should be.

Discussion: <https://lists.sr.ht/~sircmpwn/sr.ht-discuss/%3C877cwnhpni.fsf%40florness.com%3E>
Signed-off-by: David Florness <david@florness.com>
---
v1 -> v2:
  - ignore /oauth in config.example.ini: <https://lists.sr.ht/~sircmpwn/sr.ht-discuss/%3C877cwnhpni.fsf%40florness.com%3E#%3CCQI5AI6ADO6H.39CESCLMYYHS5@taiga%3E>

 gitsrht/default_query.graphql | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gitsrht/default_query.graphql b/gitsrht/default_query.graphql
index 0ddaa07..630fffb 100644
--- a/gitsrht/default_query.graphql
+++ b/gitsrht/default_query.graphql
@@ -30,7 +30,7 @@ query {

  # On this page, you have been automatically authorized to make API requests
  # with your sr.ht login cookie. If you wish to make GraphQL requests outside
  # of the browser, create a personal access token at https://meta.sr.ht/oauth
  # of the browser, create a personal access token at https://meta.sr.ht/oauth2
  #
  # curl \
  #     -H Authorization:"Bearer <your oauth token>" \
-- 
2.39.2

Re: [PATCH git.sr.ht v2] Replace meta.sr.ht's /oauth endpoint with /oauth2 in comment

Details
Message ID
<CQNAT5KMN9N0.3O288X5QGSTDH@taiga>
In-Reply-To
<87a61anwus.fsf@florness.com> (view parent)
DKIM signature
missing
Download raw message
Thanks!

To git@git.sr.ht:~sircmpwn/git.sr.ht
   e74ae7a..1f83634  master -> master
Reply to thread Export thread (mbox)