From nobody Mon Feb 22 13:55:38 2021
Authentication-Results: mail-b.sr.ht; dkim=fail header.d=cmpwn.com header.i=@cmpwn.com
Received: from out1.migadu.com (out1.migadu.com [91.121.223.63])
	by mail-b.sr.ht (Postfix) with ESMTPS id D292E11EFF3
	for <~sircmpwn/sr.ht-dev@lists.sr.ht>; Mon, 22 Feb 2021 13:55:37 +0000 (UTC)
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpwn.com; s=key1;
	t=1614002136;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=FbbnC0R4kDgsm4HfNXiRoGpowcEXKPG/VuXrmKtD7YI=;
	b=Rjd8rFOUbvpfQmc+ObHB2E9wcIyfLG/+IWMHgtvmqeb8KmdtG46ddjQhNXe99p0KoZxSk6
	Rh2j/5reBJ+rNAlD3oRB6ybxrOfSUraCqhBjXb+zxXAFkDMgpzqo6yVlycFjvAUPKMNyMY
	D44e2Gk1zVxXhW3zJ7n/9V4HdBOiHx8l2uVOFgpyoyBj3pHpxdThyOYd+hfcqjvXUgW+xJ
	JWO1NPe6s3xq/6AUGIMfQnvNhvZFvquYbpjRm4gVbE2hSM7Oe0sFEk3OQLLqPnDPPGg5Ej
	N//mExPlcsHz75UTxuaSZ5i5GRoqfYBNwKqnkzji+IrMqaOEZy0syLQkuJwWTA==
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Mon, 22 Feb 2021 08:55:35 -0500
Message-Id: <C9G408ZW2138.2E3JBOLECT0OJ@taiga>
Cc: 
Subject: Re: [PATCH builds.sr.ht v5] add Void Linux build image
X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers.
From: "Drew DeVault" <sir@cmpwn.com>
To: "Derek" <derek@meer.email>, <~sircmpwn/sr.ht-dev@lists.sr.ht>
References: <20210119065045.29296-1-derek@meer.email>
In-Reply-To: <20210119065045.29296-1-derek@meer.email>
X-Migadu-Flow: FLOW_OUT
X-Migadu-Auth-User: sir@cmpwn.com

Sorry for the delay in reviewing this, not a high priority right now.
Some feedback:

On Tue Jan 19, 2021 at 1:50 AM EST, Derek wrote:
> +++ b/images/void/genimg
> @@ -0,0 +1,136 @@
> +#!/bin/sh -eux
> +arch=3Dx86_64
> +NBD_DEVICE=3D/dev/nbd0
> +compiler=3D"${compiler:-glibc}"

glibc is a libc, not a compiler

> +qemu-img create -f qcow2 $arch/root.img.qcow2 20G

What is the size of the base install?

> +# configure DNS & networking
> +echo 'nameserver 1.1.1.1' > /mnt/etc/resolv.conf

We recently changed how we do DNS in build images: add two nameservers,
8.8.8.8, and 8.8.4.4, in that order.

> +# install necessary packages
> +run_root xbps-install -Syu
> +run_root xbps-install -y git mercurial chrony grub
> +run_root grub-install $NBD_DEVICE

We should probably explicitly install curl as well.