~sircmpwn/sr.ht-dev

core.sr.ht: Add aria-hidden="true" to icons v1 APPLIED

Steven Guikal: 1
 Add aria-hidden="true" to icons

 1 files changed, 2 insertions(+), 2 deletions(-)
#569933 alpine.yml success
#569934 archlinux.yml success
#569935 debian.yml success
Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/24499/mbox | git am -3
Learn more about email & git
View this thread in the archives

[PATCH core.sr.ht] Add aria-hidden="true" to icons Export this patch

The vast majority of icon usage is decorative, such as arrows at the end
of link buttons. For the cases where it's not, I'm sending follow-up
patches to the specific services which add appropriate aria-label to
the parent element.
---
 srht/flask.py | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/srht/flask.py b/srht/flask.py
index e7367d6..8188d4d 100644
--- a/srht/flask.py
+++ b/srht/flask.py
@@ -96,7 +96,7 @@ icon_cache = {}
def icon(i, cls=""):
    if i in icon_cache:
        svg = icon_cache[i]
        return Markup(f'<span class="icon icon-{i} {cls}">{svg}</span>')
        return Markup(f'<span class="icon icon-{i} {cls}" aria-hidden="true">{svg}</span>')
    fa_license = """<!--
        Font Awesome Free 5.3.1 by @fontawesome - https://fontawesome.com
        License - https://fontawesome.com/license/free (Icons: CC BY 4.0, Fonts: SIL OFL 1.1, Code: MIT License)
@@ -108,7 +108,7 @@ def icon(i, cls=""):
    if g and "fa_license" not in g:
        svg += fa_license
        g.fa_license = True
    return Markup(f'<span class="icon icon-{i} {cls}">{svg}</span>')
    return Markup(f'<span class="icon icon-{i} {cls}" aria-hidden="true">{svg}</span>')

@contextfunction
def coalesce_search_terms(context):
-- 
2.32.0
builds.sr.ht
core.sr.ht/patches: SUCCESS in 4m12s

[Add aria-hidden="true" to icons][0] from [Steven Guikal][1]

[0]: https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/24499
[1]: mailto:void@fluix.one

✓ #569935 SUCCESS core.sr.ht/patches/debian.yml    https://builds.sr.ht/~sircmpwn/job/569935
✓ #569934 SUCCESS core.sr.ht/patches/archlinux.yml https://builds.sr.ht/~sircmpwn/job/569934
✓ #569933 SUCCESS core.sr.ht/patches/alpine.yml    https://builds.sr.ht/~sircmpwn/job/569933
Thanks!

To git@git.sr.ht:~sircmpwn/core.sr.ht
   bc2ff7e..5afaa75  master -> master