~sircmpwn/sr.ht-dev

sourcehut.org: various link styling changes v1 NEEDS REVISION

I noticed that links were not underlined, which isn't great for
accessibility, and isn't exactly consistent with sourcehut services.

I've attempted to match the style of links on sourcehut services to
the sourcehut.org website in this patch set.

Jackson Chen (3):
  do not override text decoration on links
  make button links not underlined
  remove underline from homepage blog link

 assets/main.scss   | 10 +++++++++-
 layouts/index.html |  2 +-
 2 files changed, 10 insertions(+), 2 deletions(-)

-- 
2.42.0
#1057804 .build.yml failed
sourcehut.org/patches/.build.yml: FAILED in 24s

[various link styling changes][0] from [Jackson Chen][1]

[0]: https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/44728
[1]: mailto:jackson@jacksonchen666.com

✗ #1057804 FAILED sourcehut.org/patches/.build.yml https://builds.sr.ht/~sircmpwn/job/1057804
Yep
Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/44728/mbox | git am -3
Learn more about email & git

[PATCH sourcehut.org 1/3] do not override text decoration on links Export this patch

links can be hard to distinguish when there is no color, so don't
prevent link underlining.
---
 assets/main.scss | 1 -
 1 file changed, 1 deletion(-)

diff --git a/assets/main.scss b/assets/main.scss
index 7e5bbc6..e6afe80 100644
--- a/assets/main.scss
+++ b/assets/main.scss
@@ -187,7 +187,6 @@ form {

a {
  color: $primary;
  text-decoration: none;

  &:hover {
    color: darken($primary, 15);
-- 
2.42.0

[PATCH sourcehut.org 2/3] make button links not underlined Export this patch

matching sourcehut
---
 assets/main.scss | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/assets/main.scss b/assets/main.scss
index e6afe80..0c61afe 100644
--- a/assets/main.scss
+++ b/assets/main.scss
@@ -242,6 +242,11 @@ a {
    display: block;
    text-align: center;
  }

  $parent: &;
  @at-root a#{&} {
    text-decoration: none;
  }
}

.form-group {
-- 
2.42.0

[PATCH sourcehut.org 3/3] remove underline from homepage blog link Export this patch

---
it feels a bit too much to underline that link as well, and there is an
arrow within the link which should help indicate "you can go to it".

 assets/main.scss   | 4 ++++
 layouts/index.html | 2 +-
 2 files changed, 5 insertions(+), 1 deletion(-)

diff --git a/assets/main.scss b/assets/main.scss
index 0c61afe..66c8c97 100644
--- a/assets/main.scss
+++ b/assets/main.scss
@@ -249,6 +249,10 @@ a {
  }
}

a.blog-link {
  text-decoration: none;
}

.form-group {
  margin-bottom: 1rem;
}
diff --git a/layouts/index.html b/layouts/index.html
index 0a8111b..012ef4b 100644
--- a/layouts/index.html
+++ b/layouts/index.html
@@ -18,7 +18,7 @@
          </div>
          <div class="content">
            <h1>
              <a href="{{.Permalink}}">
              <a href="{{.Permalink}}" class="blog-link">
                <small>
                  From the blog
                  <span class="icon">
-- 
2.42.0
sourcehut.org/patches/.build.yml: FAILED in 24s

[various link styling changes][0] from [Jackson Chen][1]

[0]: https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/44728
[1]: mailto:jackson@jacksonchen666.com

✗ #1057804 FAILED sourcehut.org/patches/.build.yml https://builds.sr.ht/~sircmpwn/job/1057804