core-go: webhooks: skip webhooks with expired credentials v1 APPLIED

Conrad Hoffmann: 1
 webhooks: skip webhooks with expired credentials

 1 files changed, 3 insertions(+), 1 deletions(-)
#1107620 alpine.yml failed
Export patchset (mbox)
How do I use this?

Copy & paste the following snippet into your terminal to import this patchset into git:

curl -s https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/47374/mbox | git am -3
Learn more about email & git

[PATCH core-go] webhooks: skip webhooks with expired credentials Export this patch

The documentation states [1]:

> When the original authentication method becomes invalid (such as the
> expiration of or revocation of an OAuth 2.0 bearer token), the
> webhook is disabled.

However, this is currently not the case. Expired webhooks are indeed
filtered out in virtually all GraphQL queries (by means of core-go's
FilterWebhooks [2]), so users cannot see or delete them. They are _not_
filtered out upon scheduling, however. This commit fixes that.

The symptoms of this are that active webhooks may simply not be run - if
a user has both an expired and a valid, active webhook for some event,
the scheduling will retrieve both, fail on the expired one, and stop
processing, without any feedback to the user who scheduled the hooks.

This is a problem across all services, so core-go seems like the best
place to fix this.

[1]: https://man.sr.ht/graphql.md#webhook-authentication
[2]: https://git.sr.ht/~sircmpwn/core-go/tree/master/item/webhooks/config.go#L74,81
There is more to this that needs to be fixed to make the design
coherent, and I will start a discussion thread with all the details, but
this should at least un-break webhooks for those who have expired ones
lurking in the database.

 webhooks/queue.go | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/webhooks/queue.go b/webhooks/queue.go
index ac8107f..5cfcc67 100644
--- a/webhooks/queue.go
+++ b/webhooks/queue.go
@@ -152,7 +152,9 @@ func (queue *WebhookQueue) fetchSubscriptions(ctx context.Context,
				&sub.NodeID); err != nil {
			subs = append(subs, &sub)
			if sub.Expires.After(time.Now()) {
				subs = append(subs, &sub)

		return nil
core-go/patches/alpine.yml: FAILED in 35s

[webhooks: skip webhooks with expired credentials][0] from [Conrad Hoffmann][1]

[0]: https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/47374
[1]: mailto:ch@bitfehler.net

✗ #1107620 FAILED core-go/patches/alpine.yml https://builds.sr.ht/~sircmpwn/job/1107620

to git@git.sr.ht:~sircmpwn/core-go
  d2ad494..53966da  master -> master