~sircmpwn/sr.ht-discuss

4 3

download links don't open in sr.ht pages

Details
Message ID
<18d8547a58b.cdd2a868141799.7246282416803019458@mademonkey.com>
DKIM signature
pass
Download raw message
I am unable to get a download link to work in pages.sr.ht
 
A link like this:
<a href="example.com/file" download>Download Link</a>
fails to work

A minimum example of the problem can be found in this repository:
- https://git.sr.ht/~bamarco/srht-pages-error
Details
Message ID
<PCT8D16Ji0Dqp1xW0VX0dQUJhzICfMX5rdo79LfBVhMVOcBt5KcAnH9xd-gfrexE8wG_NeKC1_RTZq1iQhX0ShWe-51fXmevuaZY_jvsXP0=@emersion.fr>
In-Reply-To
<18d8547a58b.cdd2a868141799.7246282416803019458@mademonkey.com> (view parent)
DKIM signature
pass
Download raw message
Might be due to the CSP.
Details
Message ID
<D027GUWGIEBL.2QGOW85XKQ3AN@paper.us.eu.org>
In-Reply-To
<PCT8D16Ji0Dqp1xW0VX0dQUJhzICfMX5rdo79LfBVhMVOcBt5KcAnH9xd-gfrexE8wG_NeKC1_RTZq1iQhX0ShWe-51fXmevuaZY_jvsXP0=@emersion.fr> (view parent)
DKIM signature
pass
Download raw message
I ran into this a while ago, it's because the sandbox doesn't have
an `allow-downloads` directive.

Would y'all be okay with enabling that for pages.sr.ht?
Details
Message ID
<D09OXUUSGJ2J.3C3BL3DNCB1RT@cmpwn.com>
In-Reply-To
<D027GUWGIEBL.2QGOW85XKQ3AN@paper.us.eu.org> (view parent)
DKIM signature
pass
Download raw message
I'm open to adding allow-downloads to the CSP. Can you send a patch
doing so?
Details
Message ID
<D09U5H39DARG.HD021Z7SZ6FR@paper.us.eu.org>
In-Reply-To
<D09OXUUSGJ2J.3C3BL3DNCB1RT@cmpwn.com> (view parent)
DKIM signature
pass
Download raw message
On Tue Apr 2, 2024 at 10:02 AM EDT, Drew DeVault wrote:
> I'm open to adding allow-downloads to the CSP. Can you send a patch
> doing so?

Sure, I just send a patch here[1].

[1]: https://lists.sr.ht/~sircmpwn/sr.ht-dev/patches/50678
Reply to thread Export thread (mbox)