~sircmpwn/sr.ht-discuss

4 4

builds: Collapsed tasks in web ui auto-open again?

Details
Message ID
<20200429092745.itjcminmpfvbnde6@lucy.Speedport_W_724V_01011603_07_002>
DKIM signature
missing
Download raw message
Hi,

I'm not sure whether this is an issue with my browser (firefox) or a bug in the
builds.sr.ht web interface, so I decided to ask around here whether someone is
experiencing the same issues.

I'm not a web guy, so the terms I use might be wrong here...

When I close a pane that contains output from a build task, it shortly after I
close it pops open again.

This happens even if the task itself is _not_ running anymore, BUT only when
another task in the same build is running.

I double-checked, when the build is completed, closing a pane works as expected
(it does not pop open again later).


Can anyone reproduce this?

-- 
Matthias
Details
Message ID
<20200429134403.4218fee2@serow.humaidq.ae>
In-Reply-To
<20200429092745.itjcminmpfvbnde6@lucy.Speedport_W_724V_01011603_07_002> (view parent)
DKIM signature
pass
Download raw message
Hello,

On Wed, 29 Apr 2020 11:27:45 +0200
Matthias Beyer <mail@beyermatthias.de> wrote:
> When I close a pane that contains output from a build task, it
> shortly after I close it pops open again.

That happens while the build is in progress, as the page auto-refreshes.
A fix for this would require some JavaScript to fetch updated tasks.


-- 
Humaid AlQassimi
https://humaidq.ae
Details
Message ID
<20200429095127.5qncbl5nsdz4qnd4@lucy.Speedport_W_724V_01011603_07_002>
In-Reply-To
<20200429134403.4218fee2@serow.humaidq.ae> (view parent)
DKIM signature
missing
Download raw message
On 29-04-2020 13:44:03, Humaid AlQassimi wrote:
> That happens while the build is in progress, as the page auto-refreshes.

I see.

> A fix for this would require some JavaScript to fetch updated tasks.

And we definitively don't want that, of course. And I can see that having the
panes closed by default would be a bad solution too because if one actually
wants to look at them during the build, a refresh would close it again.

So I guess the current behaviour is the best we can have without JS - so it _is_
the best. :-)

Thanks for the fast reply.
Details
Message ID
<b8041f28-da98-4108-bdef-66a7db5dd6ef@www.fastmail.com>
In-Reply-To
<20200429134403.4218fee2@serow.humaidq.ae> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
On Wed, Apr 29, 2020, at 05:44, Humaid AlQassimi wrote:
> That happens while the build is in progress, as the page auto-
> refreshes. A fix for this would require some JavaScript to fetch
> updated tasks.

I'm also not all that much of a web guy, but couldn't each individual
pane have an iframe placed in it that loads that stage's build logs and
then each individual iframe could refresh? That wouldn't need any
JavaScript but would accomplish the same thing.

—Sam
Details
Message ID
<U_LlDQRCzF5vIcRp5TiuzmXmIMjr7WE6NF2DV9Kotx91HEq4GecyhZgpHj4Ni128gvFOuwkHaJShNZATvn25ZxN8fuQZFJ3KMTmU0-Iuj08=@emersion.fr>
In-Reply-To
<b8041f28-da98-4108-bdef-66a7db5dd6ef@www.fastmail.com> (view parent)
DKIM signature
pass
Download raw message
On Wednesday, April 29, 2020 2:57 PM, Sam Whited <sam@samwhited.com> wrote:

> On Wed, Apr 29, 2020, at 05:44, Humaid AlQassimi wrote:
>
> > That happens while the build is in progress, as the page auto-
> > refreshes. A fix for this would require some JavaScript to fetch
> > updated tasks.
>
> I'm also not all that much of a web guy, but couldn't each individual
> pane have an iframe placed in it that loads that stage's build logs and
> then each individual iframe could refresh? That wouldn't need any
> JavaScript but would accomplish the same thing.

iframes have several issues. For instance their size is fixed, so each
stage would have its own scrollbar and we'd basically hope the frame
isn't too big for the device it's displayed on.
Export thread (mbox)