~sircmpwn/sr.ht-discuss

9 5

Referencing/closing tickets in commit messages not working?

Details
Message ID
<20220510192955.rdo3igcjkmmtiuhs@haukka>
DKIM signature
missing
Download raw message
It is documented[1] that one should be able to manipulate todo tickets
via commit messages. However, in my test repository[2] I'm unable to get
it working.

AFAICT the tracker and git repo should be linked as instructed and I
should have all the required permissions as I'm the one that created the
tracker and the repository. Is this some old documentation, is the
feature broken, or am I just dumb and have missed something essential?

[1]: https://man.sr.ht/git.sr.ht/#referencing-tickets-in-git-commit-messages
[2]: https://sr.ht/~detegr/test

-- 
Antti
Details
Message ID
<CJXB4ZDB64KP.3JWZ4S03GBYY1@ians-apollo>
In-Reply-To
<20220510192955.rdo3igcjkmmtiuhs@haukka> (view parent)
DKIM signature
missing
Download raw message
I tried this feature for the first time today, and it did not work for me either.

Both the git repo and tracker are in my account.

My commit[1] message was as follows, finishing with an "Implements: ..." line:

~~~
Complete Add Snippet screen.

This includes validating a new abbreviation before allowing it to be added.

Implements: https://todo.sr.ht/~ianmjones/snippetpixie/14
~~~

The referenced ticket did not get a comment appended, and did not get closed as "IMPLEMENTED".

Could it be because the tracker is private?

Ian

[1]: https://git.sr.ht/~ianmjones/snippetpixie/commit/69ce60ddfacdaa6965e820ae9eee878b7e6c4402
Details
Message ID
<165234180493.72684.12574323089970421754@haukka.localdomain>
In-Reply-To
<CJXB4ZDB64KP.3JWZ4S03GBYY1@ians-apollo> (view parent)
DKIM signature
missing
Download raw message
Quoting Ian M. Jones (2022-05-12 02:05:57)
> The referenced ticket did not get a comment appended, and did not get
> closed as "IMPLEMENTED".
> 
> Could it be because the tracker is private?

I tried creating a public repo with a public tracker (I didn't touch the
permissions at any point) and it still does not seem to work:
https://sr.ht/~detegr/public_test/

--
Antti
Details
Message ID
<CJY2698BXZVM.2ZAL6KIO42G5U@ians-tuxedo>
In-Reply-To
<165234180493.72684.12574323089970421754@haukka.localdomain> (view parent)
DKIM signature
missing
Download raw message
Hmm, I think maybe we're at the point of needing to create a ticket?

Do you agree Drew?

If so, which tracker, git.sr.ht, todo.sr.ht, or somewhere else?

Thanks,

Ian
Details
Message ID
<87k0aqzed6.fsf@zenithia.net>
In-Reply-To
<20220510192955.rdo3igcjkmmtiuhs@haukka> (view parent)
DKIM signature
missing
Download raw message
Antti Keränen <detegr@rbx.email> writes:

> It is documented[1] that one should be able to manipulate todo tickets
> via commit messages. However, in my test repository[2] I'm unable to get
> it working.
>

FWIW, this feature was working for me at least as of 4 months ago, with
an unlisted repo and tracker:

https://git.sr.ht/~treed/mission-control/log

-- Ted Reed
Details
Message ID
<CK26SJ7VI5TQ.HJRPYTLLYU1X@nitro>
In-Reply-To
<20220510192955.rdo3igcjkmmtiuhs@haukka> (view parent)
DKIM signature
missing
Download raw message
This feature should be working again.
Details
Message ID
<CK2A07FL70G2.G4CZBZXE097K@ians-tuxedo>
In-Reply-To
<CK26SJ7VI5TQ.HJRPYTLLYU1X@nitro> (view parent)
DKIM signature
missing
Download raw message
Hey Adnan,

I just gave it a go, pushing to a `develop` branch on a private repo, it
didn't close the referenced ticket in the private tracker.

Just in case the feature only works for the default branch, I then
merged `develop` into `master` locally and pushed to sr.ht. This too did
not result in the ticket getting closed. 🤷

Am I doing something wrong?

Cheers,

Ian
Details
Message ID
<CK2A5L8N1A9T.4CUI232BS7S2@taiga>
In-Reply-To
<CK2A07FL70G2.G4CZBZXE097K@ians-tuxedo> (view parent)
DKIM signature
missing
Download raw message
It's facilitated by hub.sr.ht. Is your repo and tracker both part of a
project?
Details
Message ID
<CK2BVEB1WKLB.2LXSCZODJGWL4@ians-tuxedo>
In-Reply-To
<CK2A5L8N1A9T.4CUI232BS7S2@taiga> (view parent)
DKIM signature
missing
Download raw message
Oops, no, this repo and traker didn't have a project (it does now). 🤦

I just did another test with the repo that I previously used and that
already has a project, and it worked, thanks!

Cheers,

Ian
Details
Message ID
<CK2D67RR1PSZ.2E5IMI7MD0T1F@ians-tuxedo>
In-Reply-To
<CK2BVEB1WKLB.2LXSCZODJGWL4@ians-tuxedo> (view parent)
DKIM signature
missing
Download raw message
And just to put a bow on it, a re-test of the private repo with private
tracker with both now referenced in a private project worked too.

Ian
Reply to thread Export thread (mbox)