Howdy

I've wondered why patched I send through `git send-email` don't play nice with `git apply`.

Looking at whitespace on these patches, it appears Fastmail adds ^M (dos-style line endings)

I wonder if it would be worth it for sourcehut to pass patches through dos2unix etc.

I've solved this for now on my end but I can see how this could be annoying for some users.

It's more a Fastmail issue than a SoureHut issue to be sure, but maybe adding the dos2unix filter is worth discussing.

thanks
Brad

Fastmail adds CR on emails sent via SMTP? You should complain to your
mail administrator about this. But I think others have had successes
with Fastmail before, so it might be a local config issue?

I can confirm using git-send-email and fastmail works fine.  My setup
for receiving patches is through fastmail, mbsync and mu4e.  For sending
patches I use msmtp configured to use fastmail.

"Drew DeVault" <sir@cmpwn.com> writes:

> Fastmail adds CR on emails sent via SMTP? You should complain to your
> mail administrator about this. But I think others have had successes
> with Fastmail before, so it might be a local config issue?

My mail provider is Fastmail, too, and I've just git-send-email-ed some
random commit to myself.  I'd didn't get mangled, i.e., the encoding is
utf8 with unix line-endings which corresponds to what I use in the
project the commit originates from.

Bye,
Tassilo

Since everyone else seems to be managing, its clearly a config/locale or some other issue on my end.

Thanks for the replies everyone!

Brad

On Wed, Jul 5, 2023, at 04:29, Brad Clawsie wrote:
> Since everyone else seems to be managing, its clearly a config/locale 
> or some other issue on my end.
>
> Thanks for the replies everyone!

Bit of a wild guess, but are you on Windows, maybe in one of the native shells? I'm wondering if the extra newlines are being injected in one of the pipes.

On 23/07/05 10:27AM, Benjamin Pollack wrote:
> Bit of a wild guess, but are you on Windows, maybe in one of the native 
> shells? I'm wondering if the extra newlines are being injected in one of the 
> pipes.

I'd rather direct the debugging efforts to OP's mailer:

X-Mailer: MessagingEngine.com Webmail Interface
User-Agent: Cyrus-JMAP/3.9.0-alpha0-527-gee7b8d90aa-fm-20230629.001-gee7b8d90