Hello everyone,

I am a new SourceHut user.  I have noticed that the web version of
mailing lists does not display ".patch" files which are sent as
attachments.  I understand the desired workflow is to use 'git
send-email', though I wonder if it is possible to show attachments as
well.  Just a link would suffice: no need to show their contents in the
thread.

All the best,
Protesilaos (or simply "Prot")

-- 
Protesilaos Stavrou
https://protesilaos.com

> I am a new SourceHut user.  I have noticed that the web version of
> mailing lists does not display ".patch" files which are sent as
> attachments.  I understand the desired workflow is to use 'git
> send-email', though I wonder if it is possible to show attachments as
> well.  Just a link would suffice: no need to show their contents in the
> thread.

On the patch review UI there's an export patchset link (top right),
e.g. https://lists.sr.ht/~mpu/qbe/patches/30785
gives you https://lists.sr.ht/~mpu/qbe/patches/30785/mbox

On 2022-04-13, 16:15 +0900, Nguyễn Gia Phong <mcsinyx@disroot.org> wrote:

>> I am a new SourceHut user.  I have noticed that the web version of
>> mailing lists does not display ".patch" files which are sent as
>> attachments.  I understand the desired workflow is to use 'git
>> send-email', though I wonder if it is possible to show attachments as
>> well.  Just a link would suffice: no need to show their contents in the
>> thread.
>
> On the patch review UI there's an export patchset link (top right),
> e.g. https://lists.sr.ht/~mpu/qbe/patches/30785
> gives you https://lists.sr.ht/~mpu/qbe/patches/30785/mbox

Thank you!  This is good to know.

In that thread I can see the diff inline.  What I am referring to is a
case like this one:
<https://lists.sr.ht/~protesilaos/pulsar/%3C87czhqi8js.fsf%40gmail.com%3E>.
The user has prepared a patch with 'git format-patch' and sent it as an
attachment.  I received the file in my inbox, but the web UI has no
indicator that a file is attached.

If I export the thread, I can indeed see the patch.  My question is
whether we could have an indicator on the website like "N file[s]
attached" that would include a link to them or at least a prompt to use
the export method.

-- 
Protesilaos Stavrou
https://protesilaos.com

> The user has prepared a patch with 'git format-patch' and sent it
> as an attachment.  I received the file in my inbox, but the web UI
> has no indicator that a file is attached.

IMHO if there's no obvious way to quote reply to the patch content,
the mailing list web UI shouldn't be required to display it either.
That being said,

> My question is whether we could have an indicator on the website
> like "N file[s] attached" that would include a link

I'd also love this, e.g. for attached logs.

Having attachments displayed would also be useful when someone attaches
a logfile to a bug discussion. Right now only the normal mail-client has
these and it's pretty much impossible to see in the web UI that a log is
even attached.

--
Moritz Poldrack
https://moritz.sh

Hi all,

For what it's worth, the first patch I received from a kind
contributor came in through my mailing list as an attachment ([See
here]).

I'm not sure what more could be done to direct contributors toward the
correct procedure (I note the excellent <https://git-send-email.io/>
website) - one thought was to restrict `.patch' attachments for emails
which aren't in the valid `git send-email' format, but then that might
have other undesirable side-effects on the mailing-list.

Also, does anyone have any recommended procedure for performing git
send-email from Emacs - preferably with Magit - or is everyone just
using git directly for this operation?

Best,
JH

Protesilaos Stavrou <info@protesilaos.com> writes:

> On 2022-04-13, 16:15 +0900, Nguyễn Gia Phong <mcsinyx@disroot.org> wrote:
>
>>> I am a new SourceHut user.  I have noticed that the web version of
>>> mailing lists does not display ".patch" files which are sent as
>>> attachments.  I understand the desired workflow is to use 'git
>>> send-email', though I wonder if it is possible to show attachments as
>>> well.  Just a link would suffice: no need to show their contents in the
>>> thread.
>>
>> On the patch review UI there's an export patchset link (top right),
>> e.g. <https://lists.sr.ht/~mpu/qbe/patches/30785>
>> gives you <https://lists.sr.ht/~mpu/qbe/patches/30785/mbox>
>
> Thank you!  This is good to know.
>
> In that thread I can see the diff inline.  What I am referring to is a
> case like this one:
> <https://lists.sr.ht/~protesilaos/pulsar/%3C87czhqi8js.fsf%40gmail.com%3E>.
> The user has prepared a patch with 'git format-patch' and sent it as an
> attachment.  I received the file in my inbox, but the web UI has no
> indicator that a file is attached.
>
> If I export the thread, I can indeed see the patch.  My question is
> whether we could have an indicator on the website like "N file[s]
> attached" that would include a link to them or at least a prompt to use
> the export method.


[See
here] <https://lists.sr.ht/~johnhamelink/public-inbox/%3Cca13e146-9ee1-4f31-5fee-9a1bdd0c0c58%40disroot.org%3E#%3Cca13e146-9ee1-4f31-5fee-9a1bdd0c0c58@disroot.org%3E>

On 2022-04-13, 11:00 +0100, John Hamelink <me@johnhame.link> wrote:

> For what it's worth, the first patch I received from a kind
> contributor came in through my mailing list as an attachment ([See
> here]).
>
> [...]
> <https://lists.sr.ht/~johnhamelink/public-inbox/%3Cca13e146-9ee1-4f31-5fee-9a1bdd0c0c58%40disroot.org%3E#%3Cca13e146-9ee1-4f31-5fee-9a1bdd0c0c58@disroot.org%3E>

This is the kind of interaction that prompted me to start this thread.
Just by looking at the website, I cannot tell if the patch file is
there.  Having an indicator makes it easier for someone who is not
subscribed to the list to review the thread online.

> I'm not sure what more could be done to direct contributors toward the
> correct procedure (I note the excellent <https://git-send-email.io/>
> website) - one thought was to restrict `.patch' attachments for emails
> which aren't in the valid `git send-email' format, but then that might
> have other undesirable side-effects on the mailing-list.

Perhaps there is some good reason to enforce this.  If not though, I
wonder if it is possible to show that a file is attached and link to it.

> Also, does anyone have any recommended procedure for performing git
> send-email from Emacs - preferably with Magit - or is everyone just
> using git directly for this operation?

I am not aware of a workflow that involves Magit.  I have used
git-email before: <https://git.sr.ht/~yoctocell/git-email>

-- 
Protesilaos Stavrou
https://protesilaos.com

> I am not aware of a workflow that involves Magit.  I have used
> git-email before: <https://git.sr.ht/~yoctocell/git-email>

Thank you for this Prot! I will give it a go. I subsequently also
found [piem], which I will explore soon as well - its focus seems
more on project maintenance, so might compliment git-email well.


[piem] <https://docs.kyleam.com/piem/index.html>