Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by mail-b.sr.ht (Postfix) with ESMTPS id A274EFF104 for <~sircmpwn/sr.ht-discuss@lists.sr.ht>; Tue, 14 Jul 2020 12:44:56 +0000 (UTC) Authentication-Results: mail-b.sr.ht; dkim=fail reason="key not found in DNS" (0-bit key) header.d=samwhited.com header.i=@samwhited.com header.b=c/rvyMIK; dkim=fail reason="key not found in DNS" (0-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=et30JUO2 Received: from compute7.internal (compute7.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id 720B05C01CA for <~sircmpwn/sr.ht-discuss@lists.sr.ht>; Tue, 14 Jul 2020 08:44:56 -0400 (EDT) Received: from imap34 ([10.202.2.84]) by compute7.internal (MEProxy); Tue, 14 Jul 2020 08:44:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samwhited.com; h=mime-version:message-id:in-reply-to:references:date:from:to :subject:content-type:content-transfer-encoding; s=fm3; bh=0kEJX BYllFSsVuFC27C121qPa4KZ/tmpHOIuhqgScOA=; b=c/rvyMIKqCY7Ezgi9bJhO c5YVZq8bAEqkB62yuVPlJwvykPh/EVCQ6U5GqK2l9S33oHjTSEupSMWEelI2zXsZ RmYL8yptNaEBaS9RkWLiMeNkN9HrcpStiQM5qlj9cDkzs6rgAIo/kf5oakqMa5TX MxPugi0XETeQ7exvjE54yAG5p1emoHSddoBRhlsLgaPNWiJbHsOfFJD3FMVka4Sb q5GfdcHWfie2Iv/J/rCBGQ6ZCMqZjPLOoAUgY3mlSpPm55FGPjQ0r3JskviNrE92 XW5rk0WRFVdSyQHh+3zRRU7HUi6f/a3CGcXdFER1iUVfdZVvihn2bSWmUj34Vqua g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=0kEJXBYllFSsVuFC27C121qPa4KZ/tmpHOIuhqgSc OA=; b=et30JUO2tuxLK8a1X8VnlMZxFVcoWTkeSIdDFuHgcTSCOEAn/40VIhld4 g0ZnDu/ghLonyDglDXGQClFvIRjisNYwy0dmkhc1JuihBEH8XBfKlEmhkd7p26T7 BcKGlBySW6+MyH19ULGfy9M/Sbra0z4jFkP12zqogDPa2OsSWWQjU140g1VCoNhQ +f+CByYIOtZsU15uC4J9Kaz1FntNfKZY4IJKg6VZ5fAEJgD4D9BeL/7rJsPze2hz 7bYDu4yt6GF/VT0/1Qp1rIkCEEBsK7KdXb2KPY5Cw6n9Zxp54aq3p0CMXWfkmKaP XZZ7SYyBIgSo5V9EhmZnrQYNb2LcA== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduiedrfedtgdehkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecunecujfgurhepofgfggfkjghffffhvffutgfgsehtqh ertderreejnecuhfhrohhmpedfufgrmhcuhghhihhtvggufdcuoehsrghmsehsrghmfihh ihhtvggurdgtohhmqeenucggtffrrghtthgvrhhnpedvffeuvdduhfefvdeiheeukeffhf ekjeevgffggedtlefhhffhieevkeduvefhjeenucevlhhushhtvghrufhiiigvpedtnecu rfgrrhgrmhepmhgrihhlfhhrohhmpehsrghmsehsrghmfihhihhtvggurdgtohhm X-ME-Proxy: Received: by mailuser.nyi.internal (Postfix, from userid 501) id 0C6451460062; Tue, 14 Jul 2020 08:44:55 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface User-Agent: Cyrus-JMAP/3.3.0-dev0-613-g8a73ad6-fm-20200709.001-g8a73ad6e Mime-Version: 1.0 Message-Id: In-Reply-To: References: Date: Tue, 14 Jul 2020 08:44:35 -0400 From: "Sam Whited" To: ~sircmpwn/sr.ht-discuss@lists.sr.ht Subject: Re: Do not rebuild same commit? Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable You definitely don't want to prevent a rebuild if the hash has changed because the underlying source may still be different and the unchanged patch may react differently with different code in other parts of the code base causing failures that have now been skipped. =E2=80=94Sam On Tue, Jul 14, 2020, at 08:32, Drew DeVault wrote: > Also, after you merge or rebase commits from your feature branch to > master, their hash changes. So now we're deep comparing commits, and > we have to store the full patch somewhere instead of just the sha to > know that we've already built it. > --=20 Sam Whited