~sircmpwn/visurf-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH] nsvi: fix open -t

Details
Message ID
<20210914204738.1896-1-ecs@d2evs.net>
DKIM signature
pass
Download raw message
Patch: +3 -4
---
The BW_* flags are turned into GW_* at
desktop/browser_window.c:3135-3142
 frontends/visurf/commands.c | 1 -
 frontends/visurf/window.c   | 6 +++---
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/frontends/visurf/commands.c b/frontends/visurf/commands.c
index 06a202cef..df876130c 100644
--- a/frontends/visurf/commands.c
+++ b/frontends/visurf/commands.c
@@ -203,7 +203,6 @@ cmd_open(struct nsvi_state *state, int argc, char *argv[])
		enum browser_window_create_flags flags =
			BW_CREATE_HISTORY | BW_CREATE_TAB;
		if (!background) {
			// TODO: Why doesn't this work?
			flags |= BW_CREATE_FOREGROUND;
		}
		error = browser_window_create(flags, url, NULL, gw->bw, NULL);
diff --git a/frontends/visurf/window.c b/frontends/visurf/window.c
index 7978909b3..0e01c09b1 100644
--- a/frontends/visurf/window.c
+++ b/frontends/visurf/window.c
@@ -556,12 +556,12 @@ nsvi_gui_window_create(struct browser_window *bw,
{
	struct gui_window *gw = NULL;
	struct nsvi_window *win = NULL;
	if (flags & BW_CREATE_FOCUS_LOCATION) {
	if (flags & GW_CREATE_FOCUS_LOCATION) {
		// XXX: What should we do here? Tee up `exline open $url`?
		// Under what circumstances does this happen?
		NSLOG(netsurf, WARNING, "Location bar focus requested");
	}
	if (flags & BW_CREATE_TAB) {
	if (flags & GW_CREATE_TAB) {
		assert(existing);
		win = existing->window;
	} else if (existing) {
@@ -575,7 +575,7 @@ nsvi_gui_window_create(struct browser_window *bw,
	if (!gw) {
		gw = calloc(1, sizeof(struct gui_window));
		gw->bw = bw;
		nsvi_window_add_tab(win, gw, !(flags & BW_CREATE_FOREGROUND));
		nsvi_window_add_tab(win, gw, !(flags & GW_CREATE_FOREGROUND));
	}
	return gw;
}
-- 
2.33.0
Details
Message ID
<CEAFCX0TCPII.3H6RJ3L4MEQDH@taiga>
In-Reply-To
<20210914204738.1896-1-ecs@d2evs.net> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
Thanks!

To git@git.sr.ht:~sircmpwn/visurf
   b914b6889..b5a873d37  master -> master
Reply to thread Export thread (mbox)