~sircmpwn/visurf-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH] netsurf: don't call urlfilter on frames

Details
Message ID
<20211104135608.1432-1-umar@handlerug.me>
DKIM signature
pass
Download raw message
Patch: +2 -1
Frames and iframes don't have a reference to gui_window which causes
crashes in frontend code that assumes the reference is valid. Disable
URL filters for frames for now until a proper solution with appropriate
netsurf refactoring is implemented.
---
 desktop/browser_window.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/desktop/browser_window.c b/desktop/browser_window.c
index 522772bbc..1ef7d80f3 100644
--- a/desktop/browser_window.c
+++ b/desktop/browser_window.c
@@ -3313,7 +3313,8 @@ browser_window_navigate(struct browser_window *bw,
	assert(bw);
	assert(url);

	if (guit->window->url_filter) {
	if (bw->browser_window_type == BROWSER_WINDOW_NORMAL &&
			guit->window->url_filter) {
		url = guit->window->url_filter(bw->window, url);
	}
	NSLOG(netsurf, INFO, "bw %p, url %s", bw, nsurl_access(url));
-- 
2.33.0
Details
Message ID
<CFH1R1HL6IID.3DT98Y0KS3IT4@taiga>
In-Reply-To
<20211104135608.1432-1-umar@handlerug.me> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
Thanks!

To git@git.sr.ht:~sircmpwn/visurf
   00f0316df..b4cd6e54b  master -> master
Reply to thread Export thread (mbox)