~sircmpwn/visurf-devel

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
1

[PATCH] nsvi: don't schedule a reformat when unnecessary

Details
Message ID
<20211104143740.10607-1-umar@handlerug.me>
DKIM signature
pass
Download raw message
Patch: +0 -3
The only command that changes window dimensions is "fullscreen", and
that is already handled by xdg_toplevel_configure. It should be called
by the command code when necessary, for example, in a theoretical
"split" command that doesn't affect visurf window dimensions but does
affect the browser window.

It also fixes the crash that happens when the last tab is closed and
nsvi_window structure is freed.
---

I might be wrong with my assumption as well; but I haven't encountered
any bugs with this code removed.

 frontends/visurf/window.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/frontends/visurf/window.c b/frontends/visurf/window.c
index 6a447a268..d811d0f9d 100644
--- a/frontends/visurf/window.c
+++ b/frontends/visurf/window.c
@@ -1417,9 +1417,6 @@ nsvi_window_key_event(struct nsvi_window *win,
		return;
	case NORMAL:
		nsvi_bindings_handle(&win->state->bindings, keycode, pressed);
		if (win->ntab) {
			browser_window_schedule_reformat(win->tabs[win->tab]->bw);
		}
		return;
	case EXLINE:
		nsvi_window_handle_exline_key(win, keycode, pressed);
-- 
2.33.0
Details
Message ID
<CFHQQHVODNE4.2BK3RV4LJEIJJ@taiga>
In-Reply-To
<20211104143740.10607-1-umar@handlerug.me> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
Thanks!

To git@git.sr.ht:~sircmpwn/visurf
   b4cd6e54b..11a88e1f8  master -> master
Reply to thread Export thread (mbox)