MIME-Version: 1.0
From: Eric Farmer <erfarmer@gmail.com>
Date: Mon, 3 Jan 2022 13:19:21 -0500
Message-ID: <CAAuXPZoLFAn1o-c1+yKrVL1qQtBS5U_WWW5UJseUJjjgYXWLCw@mail.gmail.com>
Subject: Re: A new protocol and tool for PNG file attachments
To: ~skeeto/public-inbox@lists.sr.ht
Content-Type: text/plain; charset="UTF-8"

Very cool, and as usual, I love how lean your implementation is. I
recalled seeing something similar a few weeks ago:

https://github.com/Fusion/pngsource

that I first saw discussed on Hacker News:

https://news.ycombinator.com/item?id=29657072

I didn't dig too deeply through the implementation to see what was
happening under its hood. It seemed like a lot more to unpack-- yours
is much easier to read and understand.

I have a down-in-the-weeds question: what motivates the `void *`
buffer type in `crc32_update`, when it's `unsigned char *` in other
places? (I thought there might be some raw structs getting plugged in
somewhere, but I didn't see any, it looks like all of the actual
buffers being provided are also `unsigned char` arrays?)