From Daniel Jay Haskin to ~soywod/pimalaya
> Thank you for the patch. I initially did not show the seconds not to > "pollute" too much the timer, but it is my personal opinion. Instead it > could be great to add an option to customize the output, what do you > think? I almost think that customizing output is too much, most people don't need that. Maybe just an option to show the seconds, with it off by default.
From Daniel Jay Haskin to ~soywod/pimalaya
From: Daniel Jay Haskin <daniel.haskin@angel.com> --- src/client/handlers.rs | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/client/handlers.rs b/src/client/handlers.rs index de81afd..55ffac9 100644 --- a/src/client/handlers.rs +++ b/src/client/handlers.rs @@ -16,7 +16,8 @@ pub fn get(client: &dyn Client) -> Result<()> { TimerState::Running if timer.cycle.duration < 60 => { println!("[{cycle}] {}s", timer.cycle.duration) } [message trimmed]
From Daniel Jay Haskin to ~soywod/pimalaya
I volunteered in the Matrix [#pimalaya.comodoro][1] room to try out the most recent version comodoro. This is my report of that trial. The Windows artifact is [comodoro-windows.tar.gz][2], version [0.6.0][3]. The artifact itself is a tarball. While I *can* extract this via `7z` or [MSys2][4], these are third party tools. Distribution of tools using `tar.gz` is therefore frowned upon. If there's a way to use `.zip`, I would encourage that. They can be extracted with no additional tooling. Upon extraction, the tool worked fine. There are obvious subcommands that are less useful, such as `man` and `completion`. That said, I was able to get the man command to work in the [MSys2][4] environment using
From Daniel Jay Haskin to ~soywod/pimalaya
> I'm trying to figure out Himalaya on Windows. I don't know what > functions don't work for one thing. They all work, as far as I can remember. I haven't tried the notmuch stuff, though, just imap. > I wanted to move the config to > somewhere I can find it. Where ever it's at, I can't find it. The location is `C:\Users\<you>\AppData\Roaming\himalaya`. You can put a `config.toml` file in there, but it was probably already created. > It won't let me set the mail type to imap, it always does maildir or > what ever even if I type IMAP.
From Daniel Jay Haskin to ~soywod/pimalaya
On February 24, 2023 8:46:51 AM MST, Ilker Mutlu <ilker.mutlu@gmail.com> wrote: >Hi, > >I’ve recently came across himalaya from a comment on a HN thread. > >I’m on macOS. Installed via Homebrew, added my account details in a ~/.himalayarc file as follows: > >display-name = "Ilker Mutlu" >downloads-dir = "~/Downloads" >signature = "Thanks,\nIlker Mutlu" >email-listing-page-size = 30 > >[gmail] >default = true
From Skin to ~soywod/pimalaya
When I start up my linux machine, the himalaya watch commands aren't
able to start up until I've unlocked my password manager. For some
reason, between systemd and KeePassXC, two instances of my watch command
are started at the same time. My watch command is `himalaya
accounts sync`. Two copies of `himalaya accounts sync` start to run at
the same time. This nearly always results in deadlock, as both copies
try to acquire a process lock, but cannot completely sieze the whole
lock.
This patch would mitigate the problem. It causes the sync commmand to
fail if the lock cannot be acquired, instead of hanging. This allows for
one of the commands to move forward and avoids deadlock.
---
[message trimmed]
From Skin to ~soywod/pimalaya
Add a warning message for non-zero exit codes in pipe(). On most platforms, a non-zero exit status indicates a failure, and even on windows, it strongly suggests one. This patch has direct bearing on the himalaya command `himalaya watch`. This message will show up in the logs of that command, allowing the operator to understand whether or not the watch command failed or if it needs debugging. --- src/process.rs | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/src/process.rs b/src/process.rs index eb484d1..bd08558 100644 [message trimmed]
From Skin to ~soywod/pimalaya
Previously, this function didn't return exit code of the called command; rather it returned the size of the output the command wrote to stdout[1]. Now, this function returns the exit code, as originally intended. Technically, this breaks API, as the function signature type has changed (`usize` became `i32`). However, reading through the code, it is only used in the file `./src/domain/email/email.rs`. Because of type inference, the code does not break. 1: https://doc.rust-lang.org/std/io/trait.Read.html#method.read_to_end --- CHANGELOG.md | 1 + src/process.rs | 18 +++++++++++++++--- [message trimmed]
From Daniel Jay Haskin to ~soywod/pimalaya
On Windows, git is oblidged to handle the differences in line endings between OSes and make decisions about which files are text and which are binary. This file informs those decisions. --- .gitattributes | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 .gitattributes diff --git a/.gitattributes b/.gitattributes new file mode 100644 index 0000000..b42bf04 --- /dev/null +++ b/.gitattributes @@ -0,0 +1,55 @@ [message trimmed]
From Daniel Jay Haskin to ~soywod/pimalaya
On Windows, git is obliged to deal with line ending differences between OSes. This file helps git make the right decisions. --- .gitattributes | 55 ++++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 55 insertions(+) create mode 100644 .gitattributes diff --git a/.gitattributes b/.gitattributes new file mode 100644 index 0000000..b42bf04 --- /dev/null +++ b/.gitattributes @@ -0,0 +1,55 @@ * text=auto[message trimmed]