~skv

Recent activity

Re: [PATCH numberstation] Update TOTP codes when they are expired 9 months ago

From Andrey Skvortsov to ~martijnbraam/public-inbox

Hi Martijn,

do you have any feedback on the patch? Is there anything I could
possibly do to get it merged?

On 23-02-25 00:46, ~skv wrote:
> From: Andrey Skvortsov <andrej.skvortzov@gmail.com>
> 
> If system is suspended, then after resume TOTP are not updated until
> 'period' seconds are left in the wakeup state. During this time shown
> TOTP codes are wrong, because they are calculated base on the
> timestamp before system was suspended.
> ---
>  numberstation/otpurl.py | 15 ++++++++++++++-

Re: [PATCH numberstation] Use GtkSpinbox instead of GtkAdjustment to get integer value 1 year, 3 months ago

From Andrey Skvortsov to ~martijnbraam/public-inbox

Hi Martijn,

Do you have any feedback on these patches sent a month ago?
 - Use GtkSpinbox instead of GtkAdjustment to get integer value
 - Gracefully handle doubles in URLs

They fix usage of custom period for TOTP in numberstation, otherwise
it's not possible to add TOTP with custom period through UI or URL.
 
On 22-12-04 00:43, Andrey Skvortsov wrote:
> Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
> ---
>  numberstation/window.py | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

[PATCH numberstation] Use GtkSpinbox instead of GtkAdjustment to get integer value 1 year, 4 months ago

From Andrey Skvortsov to ~martijnbraam/public-inbox

Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
---
 numberstation/window.py | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/numberstation/window.py b/numberstation/window.py
index bdcf2bd..59fc9e7 100644
--- a/numberstation/window.py
+++ b/numberstation/window.py
@@ -42,8 +42,8 @@ class NumberstationWindow:
        self.add_secret = builder.get_object("add_secret")
        self.add_totp = builder.get_object("add_totp")
        self.add_counter = builder.get_object("add_counter")
        self.add_length_adj = builder.get_object("add_length_adj")
[message trimmed]

[PATCH numberstation] Gracefully handle doubles in URLs 1 year, 4 months ago

From Andrey Skvortsov to ~martijnbraam/public-inbox

Otherwise following error happens:
```
  File "numberstation/window.py", line 302, in on_save_clicked
    url = OTPUrl.create(name=name, type=type, secret=secret, duration=duration, length=length, counter=counter)
  File "numberstation/otpurl.py", line 44, in create
    return cls(otp.provisioning_uri(name=name))
  File "numberstation/otpurl.py", line 26, in __init__
    self.period = int((qs['period'][0])) if 'period' in qs else 30
ValueError: invalid literal for int() with base 10: '60.0'
```

Signed-off-by: Andrey Skvortsov <andrej.skvortzov@gmail.com>
---
 numberstation/otpurl.py | 8 ++++----
[message trimmed]