~slowjo

~slowjo/public-inbox

Last active 2 months ago
View more

Recent activity

Re: ModalNavDrawer width not configurable a month ago

From Jonathan Halmen to ~eliasnaur/gio

> I'd welcome a patch to change that if you are so inclined. I built
> that component a while ago, and I've been meaning to go back and
> update it with some of the lessons I've learned about Gio design since
> then. I don't expect to get to that in the next few weeks though.

what are some of those lessons? -- I'm sure I could manage creating a
patch that makes ModalSheet public within ModalNavDrawer, I'd expect you
have more lessons in mind though.

I'm in no particular hurry. If you tell me how you want things changed I
can try my best, otherwise I'll be patient.

> > On an unrelated note: do you by any chance also have an IRC or XMPP
> > presence that could be used without having to get a Slack account?

ModalNavDrawer width not configurable a month ago

From Jonathan Halmen to ~eliasnaur/gio

Hi,

I'm trying out Gio to maybe build a small mobile app, currently testing
the different components to see how they work.

It seems to be impossible to change the width of a ModalNavDrawer if
using the provided API / constructors, as it is hardcoded in the
ModalSheet, which is private within the ModalNavDrawer. [0]

Is this an oversight? or rather a conscious decision?
possibly I'm also not using it as intended, I'd be glad to get some
pointers.

[PATCH kimchi v3] fix site configs with path in uri 7 months ago

From Jonathan Halmen to ~emersion/public-inbox

This makes site configs such as the following work

site foo.example.org/foo/ {
  file_server /path/to/index/html/
}
---
I took the liberty to include the trailing slash in the manual as well
to have them there explicitly.

 directives.go | 2 +-
 kimchi.1.scd  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/directives.go b/directives.go
[message trimmed]

[PATCH kimchi v2] fix site configs with path in uri 7 months ago

From Jonathan Halmen to ~emersion/public-inbox

This actually makes site configs such as the following work

site foo.example.org/foo {
  file_server /path/to/index/html/
}
---
The last patch actually didn't work correctly unless a trailing slash
would be added in the config. Making sure there is going to be one is
probably better than requiring it in the config.

 directives.go | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/directives.go b/directives.go
[message trimmed]

[PATCH kimchi] fix site configs with path in uri 7 months ago

From Jonathan Halmen to ~emersion/public-inbox

---
This actually makes site configs such as the following work

site foo.example.org/foo {
  file_server /path/to/index/html/
}

 directives.go | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/directives.go b/directives.go
index 7c29464..952b474 100644
--- a/directives.go
+++ b/directives.go
[message trimmed]

Re: [PATCH kimchi v3] allow wildcard sites 7 months ago

From Jonathan Halmen to ~emersion/public-inbox

I haven't had the time to implement your proposed solution, wanted to do
that today, but I got stuck setting up working test-cases.

> foo.example.org/foo {
> file_server /srv/http/foo.example.org
> }
> *.example.org/bar {
> file_server /srv/http/fallback.example.org
> }
> :80/asdf {
> file_server /srv/http/fallback
> }
>
> We'll want to route:

[PATCH kimchi v3] allow wildcard sites 8 months ago

From Jonathan Halmen to ~emersion/public-inbox

closes: https://todo.sr.ht/~emersion/kimchi/14
---
This now works better. I'm unsure whether the NewServeMux function is
the best way to actually allocate a new Mux, or if it could be done more
easily as well. Also the naming of the new types could be improved.

 server.go | 54 ++++++++++++++++++++++++++++++++++++++++++++++++++++--
 1 file changed, 52 insertions(+), 2 deletions(-)

diff --git a/server.go b/server.go
index 18b8520..b169d83 100644
--- a/server.go
+++ b/server.go
@@ -7,6 +7,7 @@ import (
[message trimmed]

Re: [PATCH kimchi v2] allow wildcard sites 8 months ago

From Jonathan Halmen to ~emersion/public-inbox

On Tue Nov 24, 2020 at 2:07 PM CET, Simon Ser wrote:
> > This might not be the way you want this implemented, but with my limited
> > testing it seems to work.
>
> Thanks for working on this, definitely something I'd like to get
> merged.
>
> Does this patch work? New entries get added to wildcard, but I don't
> see where wildcard.ServeHTTP is called from?

I have not done extensive testing[0], but it does work.

The first time the wildcardHandler gets called, it adds itself to the
Listener.Mux with the matching pattern set to "/" in order to match

[PATCH kimchi v2] allow wildcard sites 8 months ago

From Jonathan Halmen to ~emersion/public-inbox

closes: https://todo.sr.ht/~emersion/kimchi/14
---
This might not be the way you want this implemented, but with my limited
testing it seems to work.
v2 because i seem to have messed something up the first time around.

 directives.go | 34 +++++++++++++++++++++++++++++++++-
 1 file changed, 33 insertions(+), 1 deletion(-)

diff --git a/directives.go b/directives.go
index 96b153c..d56d42b 100644
--- a/directives.go
+++ b/directives.go
@@ -44,6 +44,11 @@ func parseConfig(srv *Server, cfg scfg.Block) error {
[message trimmed]

[PATCH kimchi] allow wildcard sites 8 months ago

From Jonathan Halmen to ~emersion/public-inbox

closes: https://todo.sr.ht/~emersion/kimchi/14
---
This might not be the way you want this implemented, but with my limited
testing it seems to work.
 directives.go | 36 +++++++++++++++++++++++++++++++++++-
 1 file changed, 35 insertions(+), 1 deletion(-)

diff --git a/directives.go b/directives.go
index 96b153c..72a74d4 100644
--- a/directives.go
+++ b/directives.go
@@ -44,6 +44,11 @@ func parseConfig(srv *Server, cfg scfg.Block) error {
 
 func parseSite(srv *Server, dir *scfg.Directive) error {