~smlavine/hareimports-dev

This thread contains a patchset. You're looking at the original emails, but you may wish to use the patch review UI. Review patch
5 2

[PATCH 1/2] Add .gitignore

Details
Message ID
<20220522231021.1572-1-sebastian@sebsite.pw>
DKIM signature
pass
Download raw message
Patch: +1 -0
Signed-off-by: Sebastian <sebastian@sebsite.pw>
---
 .gitignore | 1 +
 1 file changed, 1 insertion(+)
 create mode 100644 .gitignore

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000..3ea1a66
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1 @@
/hareimports
-- 
2.35.1

[PATCH 2/2] Add Makefile

Details
Message ID
<20220522231021.1572-2-sebastian@sebsite.pw>
In-Reply-To
<20220522231021.1572-1-sebastian@sebsite.pw> (view parent)
DKIM signature
pass
Download raw message
Patch: +17 -0
Signed-off-by: Sebastian <sebastian@sebsite.pw>
---
 Makefile | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)
 create mode 100644 Makefile

diff --git a/Makefile b/Makefile
new file mode 100644
index 0000000..8304f01
--- /dev/null
+++ b/Makefile
@@ -0,0 +1,17 @@
.POSIX:
.SUFFIXES:

HARE = hare

all: hareimports

hareimports:
	$(HARE) build $(HAREFLAGS) -o $@

check:
	$(HARE) test

clean:
	rm -f hareimports

.PHONY: all clean hareimports
-- 
2.35.1
Details
Message ID
<CK6PUO11HU3N.7XHMM521UXJN@archlinux-x220>
In-Reply-To
<20220522231021.1572-1-sebastian@sebsite.pw> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
Thanks for the patch!

On Sun May 22, 2022 at 7:10 PM EDT, Sebastian wrote:
> Signed-off-by: Sebastian <sebastian@sebsite.pw>
> ---
>  .gitignore | 1 +
>  1 file changed, 1 insertion(+)
>  create mode 100644 .gitignore
>
> diff --git a/.gitignore b/.gitignore
> new file mode 100644
> index 0000000..3ea1a66
> --- /dev/null
> +++ b/.gitignore
> @@ -0,0 +1 @@
> +/hareimports

Is there a reason there is a slash at the start of the line? If not,
please send a v2 without it.

> -- 
> 2.35.1

Re: [PATCH 2/2] Add Makefile

Details
Message ID
<CK6PXH5WMDBO.3NDI7KBFHZWR3@archlinux-x220>
In-Reply-To
<20220522231021.1572-2-sebastian@sebsite.pw> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
On Sun May 22, 2022 at 7:10 PM EDT, Sebastian wrote:
> Signed-off-by: Sebastian <sebastian@sebsite.pw>
> ---
>  Makefile | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>  create mode 100644 Makefile
>
> diff --git a/Makefile b/Makefile
> new file mode 100644
> index 0000000..8304f01
> --- /dev/null
> +++ b/Makefile
> @@ -0,0 +1,17 @@
> +.POSIX:
> +.SUFFIXES:
> +
> +HARE = hare
> +
> +all: hareimports
> +
> +hareimports:
> +	$(HARE) build $(HAREFLAGS) -o $@
> +
> +check:
> +	$(HARE) test
> +
> +clean:
> +	rm -f hareimports
> +
> +.PHONY: all clean hareimports
> -- 
> 2.35.1

Thanks for the patch!
Applied as 1869964f85b71d659750b65eb79e5eb8b3e7ed83.
Details
Message ID
<987d8f4d-e0f5-4cdd-a2bd-e83e02ad0eaa@sebsite.pw>
In-Reply-To
<CK6PUO11HU3N.7XHMM521UXJN@archlinux-x220> (view parent)
DKIM signature
pass
Download raw message
May 22, 2022 20:32:01 Sebastian LaVine <mail@smlavine.com>:
> Is there a reason there is a slash at the start of the line? If not,
> please send a v2 without it.

The slash is so only files in the top level are matched. However, this 
doesn't make a difference with the current structure of the project (i.e. 
no "hareimports" directory); should I send a v2?
- Sebastian
Details
Message ID
<CK7J3LCM8QTO.25VCIAL2U0VYJ@archlinux-x220>
In-Reply-To
<987d8f4d-e0f5-4cdd-a2bd-e83e02ad0eaa@sebsite.pw> (view parent)
DKIM signature
fail
Download raw message
DKIM signature: fail
On Mon May 23, 2022 at 8:35 AM EDT, Sebastian wrote:
> May 22, 2022 20:32:01 Sebastian LaVine <mail@smlavine.com>:
> > Is there a reason there is a slash at the start of the line? If not,
> > please send a v2 without it.
>
> The slash is so only files in the top level are matched. However, this 
> doesn't make a difference with the current structure of the project (i.e. 
> no "hareimports" directory); should I send a v2?

Nope, I was just wondering. Thanks for the explanation!
Applied as 66f0b30a12ee8e3ddef53287e7e1004420e229c0.
Reply to thread Export thread (mbox)